Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Expense - Approval message for report preview in LHN is missing sender name #35261

Closed
6 tasks done
lanitochka17 opened this issue Jan 26, 2024 · 5 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 26, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.32-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

  • Admin and employee are part of the Collect workspace.
  • Admin is also the approver of the workspace.
  1. [Employee] Create a manual request in the workspace chat.
  2. [Admin] Go to workspace chat with employee.
  3. [Admin] Open expense report.
  4. [Admin] Click dropdown button next to Pay elsewhere button.
  5. [Admin] Click Approve.
  6. [Employee] Navigate to expense report and note the report preview in LHN.
  7. [Admin] Pay the request.
  8. [Employee] Navigate to expense report and note the report preview in LHN.

Expected Result:

After admin approves the request, the report preview in LHN will display "<sender_name>: approved $" format, which is the format for paid message

Actual Result:

After admin approves the request, the report preview in LHN displays only "approved $" format. The sender name is missing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6355974_1706286652016.20240125_103621.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014d658467fad4a69a
  • Upwork Job ID: 1750956987316416512
  • Last Price Increase: 2024-01-26
@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 26, 2024
Copy link

melvin-bot bot commented Jan 26, 2024

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Jan 26, 2024

Job added to Upwork: https://www.upwork.com/jobs/~014d658467fad4a69a

@melvin-bot melvin-bot bot changed the title Expense - Approval message for report preview in LHN is missing sender name [$500] Expense - Approval message for report preview in LHN is missing sender name Jan 26, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 26, 2024
Copy link

melvin-bot bot commented Jan 26, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave7.
CC @RachCHopkins

@youssef-lr
Copy link
Contributor

youssef-lr commented Jan 26, 2024

This is expected, it's similar to "paid elsewhere" message below it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

4 participants