[HOLD for #31411 - $500] Can't edit distance request right after creating it

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.32-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @aldo-expensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706234965300829

Action Performed:

1. Create free workspace
2. Create distance request in expense chat
3. Click the report preview to go to the expense report's chat
4. Click the transaction preview to get to the transaction's chat
5. Click the field Distance to edit it
6. Try to change the first waypoint

Expected Result:

Able to edit the waypoint

Actual Result:

Modal with Hmm... it's not here error shows up

Workaround:

Refresh the page so the report data reloads before trying to edit the distance request fields.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1720.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01018916e036504443
• Upwork Job ID: 1751147227689152512
• Last Price Increase: 2024-01-27

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01018916e036504443

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Modal with Hmm... it's not here error shows up

What is the root cause of that problem?

When we request money, we don't generate the transactionThreadReportID optimistically and send to back-end. So when we access the money request before the back-end API returns, it will access an invalid report (we can also see that the composer disappears in the money request after a moment). When we access the distance edit page of that invalid report, it will show not found page due to these lines.

What changes do you think we should make in order to solve the problem?

When requesting money (all types like manual, scan, distance, ...), generate the transactionThreadReportID (aka the childReportID of the created report action) optimistically and send to back-end. And the back-end should use that as the final transactionThreadReportID, just like how we optimistically generate other things like transactionID, reportActionID, ...)

And we should use that optimistically generated transactionThreadReportID (aka the childReportID of the created report action) in relevant operations like when opening the money request.

What alternative solutions did you explore? (Optional)

NA

[paultsimura]

This should be fixed after #31411, where we will send the transactionThreadReportID in the money-related API requests.

[s77rt]

@peterdbarkerUK Let's hold on #31411

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[peterdbarkerUK]

On hold for #31411

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[s77rt]

Still on hold

[s77rt]

Same ^

[s77rt]

Still on hold

[strepanier03]

Still on hold.

[s77rt]

Same ^

[strepanier03]

Hold GH is still open.

[s77rt]

#31411 is resolved. Just tested and the issue seems fixed. This can be closed.

[s77rt]

@strepanier03 We can close this one

[strepanier03]

Got it, thanks @s77rt - closing now.