Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Awaiting payment][$500] HIGH: Add possibility to leave from the workspaces #35286

Closed
waterim opened this issue Jan 28, 2024 · 50 comments
Closed

[Awaiting payment][$500] HIGH: Add possibility to leave from the workspaces #35286

waterim opened this issue Jan 28, 2024 · 50 comments
Assignees
@MonilBhavsar @MitchExpensify @waterim @rayane-djouah
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.

Comments

@waterim
Copy link
Contributor

waterim commented Jan 28, 2024 •
edited by melvin-bot bot
Loading

Problem:

Right now there are no possibilities to leave from the workspace chats or from the workspace itself. The only possible solution its to be removed fully from the workspace. But there should be a possibility for members to remove themself(leave) from the workspaces.

Solution:

As discussed in the main issue, we would like to add this possibility to leave workspaces.

  1. For all members except [Admin, Creator] we need to add a Leave button from the workspace chats in the similar way as we are doing Invite/Remove
  2. Also all members(also creators) should be able to leave from workspace rooms except: [#admin, #announce] rooms.
  3. Please follow the rules mentioned in this issue

Additional details for workspace chat:

  1. Each member is added automatically to their own workspace chat, which means members cannot be removed from their own worksapce chats
  2. Each admin is added automatically to all workspace chats, which means that admins cannot be removed from any workspace chat
  3. Anybody else can be freely added to a workspace chat via invite or mention, meaning they can also be freely removed either by themselves, or by admins
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ed8483924412de03
  • Upwork Job ID: 1777598308702314496
  • Last Price Increase: 2024-04-09
@waterim waterim mentioned this issue Jan 28, 2024
Closed
13 tasks
@waterim
Copy link
Contributor Author

waterim commented Jan 28, 2024

I think for this issue we need someone from a design team to find a perfect place for a "Leave" button.
cc: @quinthar

@waterim waterim changed the title Add possibility to leave from the workspace chats Add possibility to leave from the workspace Jan 29, 2024
@waterim waterim changed the title Add possibility to leave from the workspace Add possibility to leave from the workspaces Jan 29, 2024
@melvin-bot melvin-bot bot added the Monthly KSv2 label Jan 31, 2024
@quinthar
Copy link
Contributor

quinthar commented Feb 1, 2024

@waterim is this something you could take on?

@quinthar quinthar changed the title Add possibility to leave from the workspaces HIGH: Add possibility to leave from the workspaces Feb 1, 2024
@rezkiy37
Copy link
Contributor

rezkiy37 commented Feb 1, 2024

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

@rezkiy37
Copy link
Contributor

rezkiy37 commented Feb 1, 2024

Discussing in Slack.

@rezkiy37 rezkiy37 mentioned this issue Feb 2, 2024
Merged
50 tasks
@rezkiy37
Copy link
Contributor

rezkiy37 commented Feb 2, 2024

Continuing the discussing in Slack. Waiting on clarification about API (commands, endpoints and params).

@rezkiy37
Copy link
Contributor

rezkiy37 commented Feb 5, 2024 •
edited
Loading

Integrated functionalities for leaving a workspace and a workspace expense chat. Currently, the backend is not ready to handle requests correctly, coming soon. Preparing the PR for review.

Leave.a.workspace.chat.Offline.mp4
Leave.a.workspace.Offline.mp4

@MonilBhavsar MonilBhavsar self-assigned this Feb 6, 2024
@MonilBhavsar MonilBhavsar added Weekly KSv2 and removed Monthly KSv2 labels Feb 6, 2024
@MonilBhavsar MonilBhavsar mentioned this issue Feb 6, 2024
Closed
@rezkiy37
Copy link
Contributor

rezkiy37 commented Feb 6, 2024

The PR is being reviewed internally. Logic works on the front-end side. Waiting for the backend to test fully.

@aimane-chnaif
Copy link
Contributor

@MonilBhavsar please assign me here as well

@quinthar
Copy link
Contributor

quinthar commented Feb 9, 2024

What's the next step; who is this blocked on?

@rezkiy37
Copy link
Contributor

rezkiy37 commented Feb 9, 2024

As we agreed to wait the backend to test in a pair.

@quinthar
Copy link
Contributor

quinthar commented Feb 9, 2024

Ok, reassigning to wave8 as it's part of the new workspace page.

@JmillsExpensify JmillsExpensify moved this to Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) in [#whatsnext] Wave 08 - Collect Plan Admins Feb 9, 2024
@JmillsExpensify
Copy link

Added to release 1.

@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 9, 2024

Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 9, 2024
@rayane-djouah
Copy link
Contributor

rayane-djouah commented Apr 9, 2024 •
edited
Loading

"HIGH" priority issues are 500$ cc @mallenexpensify tagging you as per this

@MonilBhavsar
Copy link
Contributor

Thanks for thorough testing on the PR. I vote for the request 👍

@mallenexpensify mallenexpensify added the Bug Something is broken. Auto assigns a BugZero manager. label Apr 9, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 9, 2024

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mallenexpensify mallenexpensify changed the title [$250] HIGH: Add possibility to leave from the workspaces [$500] HIGH: Add possibility to leave from the workspaces Apr 9, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 9, 2024

Upwork job price has been updated to $500

@mallenexpensify
Copy link
Contributor

mallenexpensify commented Apr 9, 2024 •
edited
Loading

"HIGH" priority issues are 500$ cc @mallenexpensify tagging you as per this

Thanks @rayane-djouah , I think this might have been because the Bug label wasn't applied. I've manually updated the job to $500. Please keep tagging me if you see any issues that aren't auto-updating.

@MitchExpensify can you manage as the BZ plz? PR is in the works

@MonilBhavsar MonilBhavsar added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Apr 10, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 10, 2024

Current assignee @MitchExpensify is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 10, 2024
@MitchExpensify
Copy link
Contributor

Can do

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 18, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@MitchExpensify
Copy link
Contributor

@rayane-djouah offer sent for payment here: https://www.upwork.com/nx/wm/offer/101965429

@rayane-djouah
Copy link
Contributor

@MitchExpensify, Offer accepted, Thanks!

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 22, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@rayane-djouah
Copy link
Contributor

rayane-djouah commented Apr 26, 2024 •
edited
Loading

PR on production #35671 (comment)
Deployed on 4/22

@rayane-djouah
Copy link
Contributor

@MitchExpensify, please remove the Reviewing label and bump to Daily as payment is due

@MonilBhavsar MonilBhavsar removed the Reviewing Has a PR in review label Apr 30, 2024
@MonilBhavsar MonilBhavsar changed the title [$500] HIGH: Add possibility to leave from the workspaces [Awaiting payment][$500] HIGH: Add possibility to leave from the workspaces Apr 30, 2024
@MonilBhavsar MonilBhavsar added Daily KSv2 and removed Weekly KSv2 labels Apr 30, 2024
@MitchExpensify
Copy link
Contributor

Payment summary

Paid and contract ended in Upwork

@github-project-automation github-project-automation bot moved this from Polish to Done in [#whatsnext] #wave-collect Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MonilBhavsar MonilBhavsar

@MitchExpensify MitchExpensify

@waterim waterim

@rayane-djouah rayane-djouah

Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.
Projects
No open projects
[#whatsnext] #wave-collect
Archived in project
[#whatsnext] Wave 08 - Collect Plan Admins
Status: Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals)
Milestone
No milestone
Development

No branches or pull requests
9 participants
@quinthar @JmillsExpensify @mallenexpensify @MonilBhavsar @MitchExpensify @waterim @rezkiy37 @rayane-djouah @aimane-chnaif