[$500] [MEDIUM] Tag - Notification shows "tag" instead of custom name for tag

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.33-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #34482

Action Performed:

Precondition:

• Admin and employee are part of Collect workspace
• The Collect workspace has custom name for Tag

1. [Employee] Go to workspace chat
2. [Employee] Create a manual expense with tag
3. [Employee] Navigate to request details page
4. {Employee] Click tag and select a different tag
5. [Admin} Note that the notification shows "tag" instead of custom name for tag

Expected Result:

The notification will show custom name for tag instead of the default tag name (Tag)

Actual Result:

The notification shows default tag name (Tag). On Android and iOS app, it shows "changed the request" with no details

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6360889_1706620359946.20240130_074324__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016118ce4a2a30a489
• Upwork Job ID: 1752326219551039488
• Last Price Increase: 2024-02-24

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016118ce4a2a30a489

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[lanitochka17]

We think that this bug might be related to #wave.
CC @zanyrenney

[cead22]

Given this is push notification, I bet this is a back end issue that needs to be fixed internally

[johncschuster]

Thanks for grabbing it, @cead22!

[melvin-bot]

@cead22, @johncschuster, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[johncschuster]

Bumping to keep Melvin at bay. How's it going @cead22?

[cead22]

Sorry I'm still a bit behind and haven't gotten to this, but it's on my list

[cead22]

Looking more into this, this isn't a push notification, but a browser local notification, so I think it can be handled externally. There might be an inconsistency between how we show the report action message and the notification, but from a quick look

• BrowserNotifications.pushModifiedExpenseNotification calls
• ModifiedExpenseMessage.getForReportAction, which gets policyTagList name and passes it to
• buildMessageFragmentForValue

So I haven't gotten to the root cause, but I think we can leave that to contributors

[melvin-bot]

@cead22 @johncschuster @ishpaul777 this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

Current assignee @ishpaul777 is eligible for the Internal assigner, not assigning anyone new.

[ishpaul777]

@johncschuster @cead22 can we do reassignment i am low on bandwidth, won't be able to priortize. Last I tried to test @brandonhenry proposal it seems to be not working with desktop (this is only platform i get notifications but i dont get notification this time 😭)

[mkhutornyi]

I can take this as new C+

[johncschuster]

Thanks for letting us know, @ishpaul777, and thanks for taking it on, @mkhutornyi!

[mkhutornyi]

I think this is still waiting proposals

[Tony-MK]

@mkhutornyi, Could you please give me some feedback on my proposal.

Thank you.

[johncschuster]

@mkhutornyi bump on the above!

[melvin-bot]

@cead22, @johncschuster, @mkhutornyi Eep! 4 days overdue now. Issues have feelings too...

[johncschuster]

Bumped in Slack

[johncschuster]

Bumped again in Slack

[mkhutornyi]

I will update soon

[mkhutornyi]

I am not able to reproduce on latest main.

This is web/desktop notification after changing tag on transaction detail page, which is consistent with android/iOS.

@brandonhenry can you please confirm?