[TS migration] Migrate 'EnablePayments' pages to TypeScript

[jayeshmangwani]

Details

Fixed Issues

$ #25222
PROPOSAL: #25222 (comment)

Tests

1. Go to Settiings > Wallet > Enable Wallet > Add a bank account
2. Now we will be navigated to Additional details page, verify the working of the Additional details page with existing functionality (e.g. form should show error on empty fields and pressing button should navigate to next page)
3. To verify the IdologyQuestions page, paste below code to console on the on the Additional details step, and verify that IdologyQuestions step is working same as the current staging version

Onyx.merge('walletAdditionalDetails', {questions: [{"answer":["1251","6253","113","None of the above","Skip Question"],"prompt":"Which number goes with your address on MASONIC AVE?","type":"street.number.b"}]})

4. Next page will be OnfidoStep page, and verify that page loads perfectly and verify that OnfidoStep is working same as existing app.

• Verify that no errors appear in the JS console

Offline tests

Enable Payment Flow is disabled in offline

QA Steps

1. Go to Settiings > Wallet > Enable Wallet > Add a bank account
2. Add details on Additional details page, verify the working of the Additional details page with current staging version.
3. Verify the Onfido page, Idology questions step is working same as the current staging version.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mWeb-chrome.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

mWeb-safari_compressed.mp4

MacOS: Chrome / Safari

web_compressed.mp4

MacOS: Desktop

desktop_compressed.mp4

[melvin-bot]

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[jayeshmangwani]

@ntdiary code has been migrated, and I am working on the testing the individual pages, I will update the Tests section and the attachments once I can run the app on my side, getting some weird issue Unable to resolve reference $expo

[jayeshmangwani]

@ntdiary I have added the additional details to enable-payments page and navigated to OnfidoStep, so not sure how to bypass the onfido verification, do you have idea how can we test all the pages under enable-payments page after adding the additional details page?

enable-payment-flow.mov

[ntdiary]

merged latest main and it seems conflicts is solved now

@ntdiary bump

@jayeshmangwani, I've filled the c+ checklist, the next step is internal engineer review. 😂
BTW, the lint test is failed, I think you can add a comment like this:

App/src/components/FormScrollView.tsx

Line 3 in 3d4504e

// eslint-disable-next-line no-restricted-imports

[jayeshmangwani]

@jayeshmangwani, I've filled the c+ checklist, the next step is internal engineer review. 😂 BTW, the lint test is failed, I think you can add a comment like this:

@ntdiary Fixed the lint issue, Internal engineer was not assigned automatically to PR, thats why I pinged you , I thought if anything was missing or 🙂

[ntdiary]

Internal engineer was not assigned automatically to PR

Yeah, but Melvin automatically assigned the issue to @Gonals, I think they'll review it when they have time. : )

[jayeshmangwani]

@Gonals Whenever you get time please help with review

[Gonals]

On it. Not sure why I didn't get assigned to it

[OSBotify]

🚀 Deployed to staging by https://github.com/Gonals in version: 1.4.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/Gonals in version: 1.4.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[kbecciv]

@jayeshmangwani Which bank did you add?
QA team is unsure if the PR is Pass - tester used the Last Name "Charleson" to be able to see the Onfido flow for this PR. However, when using the Last Name "Bobbeth," only Idology questions are presented, with no Onfido verification.

Screen_Recording_20240320_103245_Chrome.1.mp4

[jayeshmangwani]

@kbecciv If I remember correctly , I tested with Regions Bank

tested with below data

Use Regions Bank
Username: user_good | Password: pass_good
CompanyName: Alberta Bobbeth Charleson
CompanyTaxID: 123456789
First Name: Alberta
Last Name: Charleson
Last SSN numbers: 3333

[kbecciv]

@jayeshmangwani The same result - no Ideology questions are presented if using above information

Screen_Recording_20240320_154133_Chrome.mp4

[jayeshmangwani]

@kbecciv locally I was able to access the IdologyQuestions page by adding data to Onyx, @ntdiary do you have any Idea how QA team can test the flow reliably

[stitesExpensify]

I think it's pretty likely that this deploy blocker is related to this PR since it's the only one that touched the bank account flow in this deploy #38701

[ntdiary]

@kbecciv locally I was able to access the IdologyQuestions page by adding data to Onyx, @ntdiary do you have any Idea how QA team can test the flow reliably

@jayeshmangwani, so far, I only know that the questions returned using "Bobbeth" are mock data, so it seems normal not to continue with the onfido flow. As for how to trigger questions and also be able to test onfido with a regular account, I don't know yet. 😞

[ntdiary]

I think it's pretty likely that this deploy blocker is related to this PR since it's the only one that touched the bank account flow in this deploy #38701

Hi, @stitesExpensify, I think it's not a blocker, because it already exists in the production branch, and added video here. :)

[OSBotify]

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.55-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅