[HOLD for payment 2024-02-14] Settings - Unexpected Increase in Padding Between Tooltip and Icon

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.34-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1, Click on "Settings."
2, Hover over the back icon in the left corner and observe an unexpected increase in padding between the back tooltip and back icon

Expected Result:

The padding between the back icon and the back tooltip should remain consistent

Actual Result:

Unexpected increase in padding between the tooltip and back icon

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6362346_1706709286285.tooltip.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[esh-g]

Regression from: #35126
@dukenv0307

[dangrous]

Yep! @esh-g has it right - I commented here and will look into it further shortly

[dangrous]

I'm removing the blocker label here since it's a very minor issue; a fix is in progress but I don't think this needs to block anything.

[dangrous]

@dukenv0307 do you mind commenting on this so I can assign you? @c3024 I already added you since I could for some reason. Thanks!

[dukenv0307]

Thanks I will raise the PR tomorrow

[dukenv0307]

@c3024 The PR is ready for review.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[dangrous]

hi! no rush but would love a clarification on ^ - @dukenv0307 are you saying here that it's basically not this PR that caused the issue, but another PR combined with this one that unluckily got merged at the same time?

[dukenv0307]

If needed, I can raise another PR to fix this.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix extra padding of back button and tooltip #35643

If no regressions arise, payment will be issued on 2024-02-14. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment (Needs manual offer from BZ)
• @dukenv0307 requires payment (Needs manual offer from BZ)

[dangrous]

Just to bring the conversation back here, we determined no regression on this PR - just an interaction between two PRs that was not testable at the time

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @strepanier03 you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @c3024 paid $(AMOUNT) via Upwork (LINK)
• ROLE: @dukenv0307 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@strepanier03)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[c3024]

This is a regression and needs no payment.

[strepanier03]

Great, if no payment is needed then I'm going to close it out. Thanks everyone!