Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hold for #34056]Adding a comment in domain chat #expensifail.com crashes #35538

Closed
6 tasks done
m-natarajan opened this issue Feb 1, 2024 · 39 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Feb 1, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.35-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @aldo-expensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706747593037209

Action Performed:

  1. Sign into https://staging.new.expensify.com/r/75431276 on a browser with an expensifail account
  2. Click the search bar in the upper left corner and search for "#expensifail.com" room
  3. Try to add a comment
  4. Verify you get an error (Auth GetRestrictedAuthTokenByEmail returned an error)

Expected Result:

The comment should be added

Actual Result:

Error appears: Unexpected error while posting the comment, please try again laterAuth GetRestrictedAuthTokenByEmail returned an error

Logs: https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%2284e610de98092d8a-YVR%22)+AND+timestamp:[2024-01-31T23:26:57.858Z+TO+2024-02-01T01:26:57.858Z]&index=logs_expensify-026557

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
image (3)

image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018aa801eb047294a0
  • Upwork Job ID: 1753560316765069312
  • Last Price Increase: 2024-02-02
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Feb 1, 2024
Copy link

melvin-bot bot commented Feb 1, 2024

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@Christinadobrzyn Christinadobrzyn removed the Needs Reproduction Reproducible steps needed label Feb 2, 2024
@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Feb 2, 2024

I can reproduce this - updated the OP with the details.

I think this needs to be internal? adding that label for a buddy check.

@Christinadobrzyn Christinadobrzyn added the Internal Requires API changes or must be handled by Expensify staff label Feb 2, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

Job added to Upwork: https://www.upwork.com/jobs/~018aa801eb047294a0

Copy link

melvin-bot bot commented Feb 2, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @getusha (Internal)

@Christinadobrzyn
Copy link
Contributor

I think this can be part of vip-vsb since it relates to chat - I think this need to be internal based on the error

@melvin-bot melvin-bot bot removed the Overdue label Feb 6, 2024
@Christinadobrzyn Christinadobrzyn changed the title Adding a comment in domain char #expensifail.com crashes Adding a comment in domain chat #expensifail.com crashes Feb 6, 2024
@Christinadobrzyn
Copy link
Contributor

Asking in the vsb Slack channel how we want to handle this one - https://expensify.slack.com/archives/C066HJM2CAZ/p1707247660309079

@Christinadobrzyn
Copy link
Contributor

Since this is internal - we're waiting for someone to pick this up

@melvin-bot melvin-bot bot added the Overdue label Feb 12, 2024
Copy link

melvin-bot bot commented Feb 12, 2024

@Christinadobrzyn, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Feb 12, 2024

Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

@Christinadobrzyn Christinadobrzyn added the Hot Pick Ready for an engineer to pick up and run with label Feb 12, 2024
@Christinadobrzyn
Copy link
Contributor

Going to add a few more labels to this job to try and get someone internally to pick it up. I think this is an internal job and I believe it is ready for someone to grab!

@melvin-bot melvin-bot bot removed the Overdue label Feb 12, 2024
@Christinadobrzyn
Copy link
Contributor

still waiting on this to get picked up

Copy link

melvin-bot bot commented Feb 15, 2024

@Christinadobrzyn @getusha this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Feb 15, 2024

Keeping this internal for eng to pick up when they have the bandwidth!

@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2024
Copy link

melvin-bot bot commented Feb 29, 2024

@Christinadobrzyn @getusha this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

@Christinadobrzyn
Copy link
Contributor

There doesn't seem to be a way to add QA to our expensifail.com room in NewDot to test this. Asking @mallenexpensify if he can test for us to see if this is still happening - https://expensify.slack.com/archives/C01SKUP7QR0/p1709329998662989?thread_ts=1709307595.245699&cid=C01SKUP7QR0

@Christinadobrzyn
Copy link
Contributor

I think this is still happening and I think it needs to be internal since it's affecting the expensifail.com accounts.

@mallenexpensify
Copy link
Contributor

Was able to reproduce.
image

Logs -
logs-2024-03-01 23_38_25.029.txt

I logged out/in, and cleared cookies + local storage and the issue persists. Even though it shows an error when sending, when I signed back in, I saw messages that went through.

image

@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2024
@Christinadobrzyn
Copy link
Contributor

Oh interesting- since it's only affecting this one room, I'm not sure if this needs to be fixed @getusha what's your take?

@melvin-bot melvin-bot bot removed the Overdue label Mar 4, 2024
@Christinadobrzyn
Copy link
Contributor

I think this should still be evaluated by an internal engineer so going to keep this open for pick up

@melvin-bot melvin-bot bot added the Overdue label Mar 11, 2024
@Christinadobrzyn
Copy link
Contributor

this is ready for pick up by an internal engineer

@melvin-bot melvin-bot bot removed the Overdue label Mar 12, 2024
@Christinadobrzyn
Copy link
Contributor

This is ready for an internal engineer when possible

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@Christinadobrzyn
Copy link
Contributor

I'm still seeing this in staging

2024-03-15_13-48-29.mp4

@melvin-bot melvin-bot bot added the Overdue label Mar 18, 2024
Copy link

melvin-bot bot commented Mar 18, 2024

@Christinadobrzyn, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Christinadobrzyn
Copy link
Contributor

Asking if we can merge this with - #34056

@melvin-bot melvin-bot bot removed the Overdue label Mar 19, 2024
@Christinadobrzyn
Copy link
Contributor

I guess this is different from #34056 so we'll keep this open to see if we can find someone to grab it

@Christinadobrzyn
Copy link
Contributor

waiting for this to get picked up

@Christinadobrzyn Christinadobrzyn added Daily KSv2 and removed Daily KSv2 labels Mar 27, 2024
@Christinadobrzyn Christinadobrzyn changed the title Adding a comment in domain chat #expensifail.com crashes [hold for #34056]Adding a comment in domain chat #expensifail.com crashes Mar 27, 2024
@Christinadobrzyn Christinadobrzyn added Weekly KSv2 and removed Daily KSv2 labels Mar 27, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Third week)

@mallenexpensify
Copy link
Contributor

@Christinadobrzyn , let's close this for now. We can reopen or create a new one if it continues to be a pressing problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
No open projects
Status: CRITICAL
Development

No branches or pull requests

5 participants