[$500] LHN - First line and second line of the message are visible on LHN

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.35-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4262578&group_by=cases:section_id&group_order=asc&group_id=296775
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Log in with the following account - [email protected]
2. Once logged in navigate to each of the conversations available (multiline+1 to multiline+9) and check LHN
3. Verify each of the multiline preview messages are displayed correctly in the LHN, only the first line of the message should be visible

Expected Result:

Only the first line of the message should be visible on LHN

Actual Result:

First line and second line of the message are visible on LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01be20407fd253f3da
• Upwork Job ID: 1753175258047799296
• Last Price Increase: 2024-02-22
• Automatic offers:
• akinwale | Reviewer | 0
• dukenv0307 | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01be20407fd253f3da

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• LHN - First line and second line of the message are visible on LHN

What is the root cause of that problem?

• With ADDCOMMENT action, the message to display in LHN is from lastMessageText, that was removed all the line break character. See the logic

What changes do you think we should make in order to solve the problem?

• With the ADDCOMMENT action, we can get the message to display from lastMessageHtml, then use parser.htmlToText
• For example, we can update this to:

     return lastMessageTextFromReport || (lastActionName === 'ADDCOMMENT' ? parser.htmlToText(report?.lastMessageText).split("\n")[0] : report?.lastMessageHtml ?? '');

What alternative solutions did you explore? (Optional)

[FitseTLT]

This is intentional behavior that aligns with other social media apps; when the last message has text with line breaks it will be joined with space and displayed on the last message preview.

[puneetlath]

Hmm, I agree. I think this is the intentional behavior.

@kbecciv is the expected behavior from a regression test?

[kbecciv]

@puneetlath The issue is raised when executing steps in TR https://expensify.testrail.io/index.php?/tests/view/4262578&group_by=cases:section_id&group_order=asc&group_id=296775

[puneetlath]

Ok, seems like a legit bug then. @kbecciv would you mind confirming if you're still seeing the issue?

[kbecciv]

@puneetlath Checking

[kbecciv]

Issue is still reproducible

[melvin-bot]

Current assignee @ntdiary is eligible for the External assigner, not assigning anyone new.

[ghost]

Can't login using this account - [email protected], because I can't enter magic code

[melvin-bot]

@puneetlath, @akinwale, @dukenv0307, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[puneetlath]

Still on the list. Have been working on higher priority #newdot-quality and #fast-apis stuff.

[puneetlath]

Asking for a re-test to see if this is still occurring.

[m-natarajan]

Still reproducible

[puneetlath]

Will try to get to it at some point, but it's really not high priority.

[puneetlath]

I'm going to close this as I don't think this is a priority right now with #vip-vsb being closed. Comment or reopen if you disagree!

[akinwale]

@puneetlath This would be eligible for compensation since a PR was created and we went through the review process.

[puneetlath]

Fair enough. I've paid out the contracts. Thanks y'all.