[HOLD for payment 2024-03-13] [$500] Upgrade Electron package to latest version #35600
Comments
blimpich
added
External
|
Job added to Upwork: https://www.upwork.com/jobs/~01411beff5fb7fab7c |
melvin-bot
bot
changed the title
melvin-bot
bot
added
the
Help Wanted
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane ( |
|
Triggered auto assignment to @MitchExpensify ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Need to update electron What is the root cause of that problem?Visibility bug will improve our user experience on electron What changes do you think we should make in order to solve the problem?We should wait for the next major version to get released around feb 20th. Only then upgrade to that electron version with the steps documented in https://github.com/Expensify/App/blob/4f103255b77271d60666d39a0670104d113c44b5/desktop/README.md#testing-electron-auto-update. I did a spot check against https://www.electronjs.org/docs/latest/breaking-changes make sure we don't have any larger migration changes needed. As all the deprecated and breaking changes are not used in our app yet. What alternative solutions did you explore? (Optional) |
|
@blimpich, @rushatgabhane, @MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick! |
|
@blimpich based on #35600 (comment) should this be |
|
We don't need to wait for the upstream fix in my opinion. Once we are updated to the latest major version there will be little risk in bumping the minor version needed to make use of that upstream Electron PR. This can be done in parallel. And actually I'd prefer that this be done in parallel so that we can sort out any issues / regression that bumping the major version might cause now rather than later. However, after thinking about it, I would like this upgrade to be done once the latest Electron major version is released on February 20th. So lets table this issue until then. Hopefully the upstream issue is fixed by then and we get two birds with one stone. |
|
Upstream issue is officially fixed 🎉 electron/electron#38955 (comment) |
|
Let's see if it's just a minor version bump. Would you like a proposal for that too? |
|
@jeremy-croff Not sure if I understand, do you mean one proposal for the major version upgrade and one proposal for the minor version upgrade? If so, no, just the major. Or really simply the latest version once 29 is released. |
|
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
|
What is our next step here? Is this still a problem or was it resolved here: electron/electron#38955 (comment)? |
|
@MitchExpensify we're waiting till February 20th, which is when the newest stable version of Electron should be released according to this. |
|
@blimpich @MitchExpensify There's some turbulence with the expected fix. Latest is that the occlusion fix got reverted: |
|
Thanks for the update |
|
@blimpich @rushatgabhane @MitchExpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
|
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
|
Not overdue. Tomorrow the newest version of electron comes out and then we can start the upgrade. |
|
29 is out, lets get started on this.
|
|
@jeremy-croff @rushatgabhane are you both still good to work on this? |
Can start today |
melvin-bot
bot
removed
the
Help Wanted
|
📣 @jeremy-croff 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
melvin-bot
bot
added
Reviewing
melvin-bot
bot
added
Weekly
melvin-bot
bot
changed the title
|
|
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-03-13. 🎊 For reference, here are some details about the assignees on this issue:
|
This comment was marked as resolved.
This comment was marked as resolved.
|
Reminder set to pay |
|
@MitchExpensify checklist not applicable because this isn't a bug / feature |
|
Payment summary:
|
|
request here https://staging.new.expensify.com/r/7234444884705194 |
|
Contract ended and paid @jeremy-croff |
|
$500 approved for @rushatgabhane based on summary. |
Problem
Electron is a core part of our app and we are currently several major versions behind. We should be up to date in order to gain the benefit of up-to-date security patches and also added functionality. One example is that #34829 will be partially fixed when this Electron issue gets closed, but only if we are on the most recent version.
Solution
Upgrade to the most recent stable version of Electron. As of the time of writing this issue that is major version
28but major version29should become the new latest stable version sometime in February. Keep that in mind as this issue progresses.Note: for testing make sure to test the electron auto updater
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: