[HOLD for payment 2024-04-05] [$500] [Wave Collect] [Ideal Nav] Chat list scroll position is reset on refocus

[hayata-suenaga]

Action Performed:

1. Click the Chat Button on the bottom tab
2. Make sure that you have enough number of chats so that the list can be scrolled. Scroll the list to a random position.
3. Click Settings Icon 🔧 to go to Settings page. Click the Chat icon again to navigate back to Chats page.

Expected Result:

The scroll position of the chat list should be preserved.

Actual Result:

The scroll position is reset.

Additional Note

As part of a potential solution, we can make sure that we don't reload the chat/report list when switching between Chat and Settings on the Bottom Tab.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

video -> #33280 (comment)

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01af2fb1053774c16b
• Upwork Job ID: 1754565125866393600
• Last Price Increase: 2024-02-05
• Automatic offers:
• situchan | Reviewer | 0

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

@muttmuure, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01af2fb1053774c16b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[jeremy-croff]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We are not able to remember the state of the chats in the home route, when navigating to the all-settings page.

What is the root cause of that problem?

This is because BOTTOM_TAB_NAVIGATOR is responsible for both routes and can only display one at a time. When navigating to all-settings it will unmount the chats home route and it's chat components.

What changes do you think we should make in order to solve the problem?

We could move the all-settings route, and place it in our existing RIGHT_MODAL_NAVIGATOR. This Navigator can render alongside the BOTTOM_TAB_NAVIGATOR. this navigator is a modal that would overlay the home chats. So that when you close it would show the previous underlying state.

This implementation requires correct verification of back buttons, as there will be some deeplinking in all the nested navigation routes of all-settings. Overall not a small bug fix but rather a new feature.

What alternative solutions did you explore? (Optional)

[hayata-suenaga]

still accepting proposals

[adamgrzybowski]

Hey @hayata-suenaga this task may be something I should take a look at

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

@muttmuure, @adamgrzybowski, @hayata-suenaga, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Wave 8] [Ideal Nav] Save scroll position on HOME screen #38161

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @adamgrzybowski does not require payment (Contractor)
• @situchan requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[hayata-suenaga]

@situchan could you do the checklist when you have time? 😄

[muttmuure]

Will get to this tomorrow

[muttmuure]

@situchan paid $500 for C+

[muttmuure]

@situchan waiting for you to complete the checklist

[hayata-suenaga]

@muttmuure, I think situation is OOO for whole April. Let's wait for them to come back. I changed the priority of this issue to weekly 🙇

[muttmuure]

Not overdue

[muttmuure]

Looks like this was already paid out