Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Awaiting Payment 20th Feb] [Wave Collect] [Account Settings] Update Profile page #35603

Closed
mountiny opened this issue Feb 1, 2024 · 15 comments
Assignees
Labels
Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@mountiny
Copy link
Contributor

mountiny commented Feb 1, 2024

Coming from tracking issue for this initiative.

Using the Figma final mocks, please update the Account Settings Profile page in the new ideal navigation layout to look like this:

image

For help with anything unclear, please, post in wave8 room.

Please tag design team for a review on the PR before merging.

cc @trjExpensify @dannymcclain

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d6b2f411bfdad74d
  • Upwork Job ID: 1753492818731462656
  • Last Price Increase: 2024-02-02
Issue OwnerCurrent Issue Owner: @JmillsExpensify
@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. labels Feb 1, 2024
@mountiny mountiny self-assigned this Feb 1, 2024
Copy link

melvin-bot bot commented Feb 1, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 1, 2024
@mountiny mountiny moved this to Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) in [#whatsnext] Wave 08 - Collect Plan Admins Feb 1, 2024
@dukenv0307
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update Profile page with new UI

What is the root cause of that problem?

This is a new feature

What changes do you think we should make in order to solve the problem?

  1. To display the icon in the header, we can allow to pass icon to HeaderWithBackButton component and display it before the title

  2. For each public and private personal detail, we can use Section component. In each section, we can re-use the UI in ProfilePage and PersonalDetailsInitialPage

  3. Use usePrivatePersonalDetails hook to get private personal detail information and we can display loading page in each section if the data is loading.

  4. After refactoring, we can remove PersonalDetailsInitialPage as well

What alternative solutions did you explore? (Optional)

NA

@filip-solecki
Copy link
Contributor

Hi! I am Filip from Software Mansion and I will work on this issue!

@trjExpensify
Copy link
Contributor

Awesome, assigning you @filip-solecki!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Feb 2, 2024
@mountiny mountiny added the Internal Requires API changes or must be handled by Expensify staff label Feb 2, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01d6b2f411bfdad74d

Copy link

melvin-bot bot commented Feb 2, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @cubuspl42 (Internal)

@mountiny mountiny assigned situchan and unassigned cubuspl42 Feb 2, 2024
@trjExpensify trjExpensify changed the title [Wave8] [Account Settings] Update Profile page [Awaiting Payment 20th Feb] [Wave8] [Account Settings] Update Profile page Feb 16, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Feb 26, 2024
Copy link

melvin-bot bot commented Feb 26, 2024

This issue has not been updated in over 15 days. @JmillsExpensify, @mountiny, @situchan, @filip-solecki eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@mountiny
Copy link
Contributor Author

$500 to @situchan

@mountiny mountiny added Weekly KSv2 Daily KSv2 and removed Reviewing Has a PR in review Monthly KSv2 Weekly KSv2 labels Feb 26, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 29, 2024
Copy link

melvin-bot bot commented Mar 1, 2024

@JmillsExpensify, @mountiny, @situchan, @filip-solecki Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@trjExpensify trjExpensify moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Mar 5, 2024
@trjExpensify
Copy link
Contributor

Can this be closed out?

@trjExpensify trjExpensify changed the title [Awaiting Payment 20th Feb] [Wave8] [Account Settings] Update Profile page [Awaiting Payment 20th Feb] [Wave Collect] [Account Settings] Update Profile page Mar 5, 2024
Copy link

melvin-bot bot commented Mar 5, 2024

@JmillsExpensify, @mountiny, @situchan, @filip-solecki Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented Mar 5, 2024

@JmillsExpensify, @mountiny, @situchan, @filip-solecki 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@JmillsExpensify
Copy link

Good question. I wanted to clarify that only @situchan should be compensated for this issue?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 6, 2024
Copy link

melvin-bot bot commented Mar 11, 2024

@JmillsExpensify, @mountiny, @situchan, @filip-solecki Huh... This is 4 days overdue. Who can take care of this?

@mountiny
Copy link
Contributor Author

Payment seems to have been done here #36016 so i will close this one

@melvin-bot melvin-bot bot removed the Overdue label Mar 11, 2024
@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Status: Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals)
Development

No branches or pull requests

7 participants