Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-20] [Wave8] [Account Settings] Update Share Code page #35605

Closed
mountiny opened this issue Feb 1, 2024 · 13 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@mountiny
Copy link
Contributor

mountiny commented Feb 1, 2024

Coming from tracking issue for this initiative.

Using the Figma final mocks, please update the Account Settings Share Code page in the new ideal navigation layout to look like this:

image

For help with anything unclear, please, post in wave8 room.

Please tag design team for a review on the PR before merging.

cc @trjExpensify @dannymcclain

Issue OwnerCurrent Issue Owner: @sonialiap
@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. labels Feb 1, 2024
Copy link

melvin-bot bot commented Feb 1, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 1, 2024
@mountiny mountiny moved this to Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) in [#whatsnext] Wave 08 - Collect Plan Admins Feb 1, 2024
@mountiny mountiny self-assigned this Feb 2, 2024
@mountiny
Copy link
Contributor Author

mountiny commented Feb 2, 2024

Will be handled by SWM

@trjExpensify
Copy link
Contributor

Updated the mock in the OP of this issue to replace the placeholder subheader copy!

@filip-solecki
Copy link
Contributor

Note: Won't apply rounded QRCode cause library does not support it.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Feb 8, 2024
@blimpich
Copy link
Contributor

blimpich commented Feb 8, 2024

Assigning @situchan as they are reviewing the associated PR.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 13, 2024
@melvin-bot melvin-bot bot changed the title [HOLD App#35603] [Wave8] [Account Settings] Update Share Code page [HOLD for payment 2024-02-20] [HOLD App#35603] [Wave8] [Account Settings] Update Share Code page Feb 13, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 13, 2024
Copy link

melvin-bot bot commented Feb 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-20. 🎊

For reference, here are some details about the assignees on this issue:

  • @situchan requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Feb 13, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@situchan] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@garrettmknight garrettmknight added the Bug Something is broken. Auto assigns a BugZero manager. label Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 14, 2024
@garrettmknight garrettmknight removed their assignment Feb 14, 2024
@garrettmknight garrettmknight removed the Bug Something is broken. Auto assigns a BugZero manager. label Feb 14, 2024
@garrettmknight
Copy link
Contributor

@sonialiap reassigning for payment since I'll be OOO when the date comes. Thanks!

@mountiny mountiny changed the title [HOLD for payment 2024-02-20] [HOLD App#35603] [Wave8] [Account Settings] Update Share Code page [HOLD for payment 2024-02-20] [Wave8] [Account Settings] Update Share Code page Feb 14, 2024
@mountiny
Copy link
Contributor Author

$500 to @situchan and no regression tests required

@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2024
@sonialiap
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Feb 19, 2024
@sonialiap
Copy link
Contributor

Paid ✔️

@github-project-automation github-project-automation bot moved this from Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) to Done in [#whatsnext] Wave 08 - Collect Plan Admins Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
No open projects
Development

No branches or pull requests

7 participants