-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-02-20] [Wave8] [Account Settings] Update Share Code page #35605
Comments
Triggered auto assignment to @garrettmknight ( |
Will be handled by SWM |
Updated the mock in the OP of this issue to replace the placeholder subheader copy! |
Note: Won't apply rounded QRCode cause library does not support it. |
Assigning @situchan as they are reviewing the associated PR. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-02-20. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Triggered auto assignment to @sonialiap ( |
@sonialiap reassigning for payment since I'll be OOO when the date comes. Thanks! |
$500 to @situchan and no regression tests required |
@situchan $500 - offer sent Job https://www.upwork.com/ab/applicants/1759618198049271808/job-details |
Paid ✔️ |
Coming from tracking issue for this initiative.
Using the Figma final mocks, please update the Account Settings Share Code page in the new ideal navigation layout to look like this:
For help with anything unclear, please, post in wave8 room.
Please tag design team for a review on the PR before merging.
cc @trjExpensify @dannymcclain
Issue Owner
Current Issue Owner: @sonialiapThe text was updated successfully, but these errors were encountered: