[$500] [Wave Collect] [Ideal Nav] Going back to Workspace Settings page resets the selected setting item

[hayata-suenaga]

Action Performed:

1. Make sure that you open a workspace for which you're an admin
2. Go to 🔧 Workspace Settings page
3. Select any settings item other than Overview
4. Click the Chat icon to go to Chat page
5. Click 🔧 to go to Workspace Settings page

Expected Result:

The previously selected item should be focused when going back to Workspace Settings page.

Actual Result:

Check the focus is on Overview`, not the item you selected previously.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

video -> #35613 (comment)

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e287e0122a51dbb7
• Upwork Job ID: 1753503953429983232
• Last Price Increase: 2024-02-02

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[s77rt]

The attached video is unrelated. This is the bug

Screen.Recording.2024-02-02.at.5.28.54.PM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e287e0122a51dbb7

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Going back to Workspace Settings page resets the selected setting item

What is the root cause of that problem?

the selected/focused item depends on the active route

App/src/pages/workspace/WorkspaceInitialPage.js

Line 214 in 3a610af

focused={activeRoute && activeRoute.startsWith(item.routeName)}

and we currently just navigate to overview by default so overview is always opened and focused.

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

Lines 70 to 71 in 3a610af

	activeWorkspaceID ? Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(activeWorkspaceID)) : Navigation.navigate(ROUTES.ALL_SETTINGS),
	)

What changes do you think we should make in order to solve the problem?

We need to save in Onyx the last menu item a user navigated for a workspace by persisting it whenever a user presses a menu here

App/src/pages/workspace/WorkspaceInitialPage.js

Lines 211 to 212 in 3a610af

	onPress={item.action}
	brickRoadIndicator={item.brickRoadIndicator}

whenever setting is pressed we will navigate to the saved last menu item here.

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

Lines 70 to 71 in 3a610af

	activeWorkspaceID ? Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(activeWorkspaceID)) : Navigation.navigate(ROUTES.ALL_SETTINGS),
	)

What alternative solutions did you explore? (Optional)

Optionally we can also find the last menu item from the route history (latest workspace setting page opened for the workspace) and navigate to it here

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

Lines 70 to 71 in 3a610af

	activeWorkspaceID ? Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(activeWorkspaceID)) : Navigation.navigate(ROUTES.ALL_SETTINGS),
	)

but this will not work when the user has refreshed after navigating away from the workspace settings page

[MitchExpensify]

Why should it open the same workspace settings tab when you leave to "chat" and then return by clicking "Settings" @hayata-suenaga ? Aren't you opening Settings for the first time everytime you click "Settings"? (In which case "Overview" makes sense to me every time you click "Settings")

[hayata-suenaga]

The attached video is unrelated. This is the bug

ops thank you for pointing that out 🙇

Aren't you opening Settings for the first time everytime you click "Settings"? (In which case "Overview" makes sense to me every time you click "Settings")

I'll ask about this in Slack if this is the intended design 👍

asking about this here

[MitchExpensify]

Cool, following along there 👁️

[hayata-suenaga]

bumped the convo

[WojtekBoman]

Hey! I’m Wojtek from Software Mansion, an expert agency, and I’d like to work on this issue.

[mountiny]

moving this over to SWMs hands for focused and urgent resolution 🙇

[melvin-bot]

@MitchExpensify, @WojtekBoman, @thesahindia, @hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

[hayata-suenaga]

@WojtekBoman will work on this

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[hayata-suenaga]

@cubuspl42 @WojtekBoman from an expert agency is going to open a PR for this issue
please review the PR once it's open 🙇

[cubuspl42]

I'm on it 👍

[melvin-bot]

@cubuspl42, @MitchExpensify, @WojtekBoman, @hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

[hayata-suenaga]

The PR was merged but it caused a regression. Wojciech is going to work on a PR to fix the regression.

[hayata-suenaga]

The fix PR was merged

[melvin-bot]

@cubuspl42, @MitchExpensify, @WojtekBoman, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[hayata-suenaga]

the pr was merged and we're just waiting for payment after regression period is over

[melvin-bot]

@cubuspl42, @MitchExpensify, @WojtekBoman, @hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

[hayata-suenaga]

reviewing label was not automatically removed when the PR was merged 🤔

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[hayata-suenaga]

I confirmed this is not reproducible. Closing the issue