[HOLD for payment 2024-02-14] [Wave 8] [Ideal Nav] Big New Workspace button doesn't work

[hayata-suenaga]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Logs: N/A
Expensify/Expensify Issue URL: N/A
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706831528469869

Action Performed:

1. Create a new account (to test this, the account cannot have any existing workspace. that's why it's recommended you create a new account).
2. Bottom tab -> 🔧 Settings -> Workspaces
3. Click the big New Workspace button that appear middle of the content pane

Expected Result:

A new workspace should be created.

Actual Result:

Nothing happens.

Workaround:

The user can click the small New workspace button at the top-right color of the Settings page

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[cdOut]

Hello, I will be looking into this issue.

[hayata-suenaga]

hi @cdOut 👋 are you from SWM?

this issue should be fixed with this PR which was merged to main recently 👍

[cdOut]

@hayata-suenaga Yes, I am from SWM. Let me know whether this still persists and whether I should still work on this.

[hayata-suenaga]

I'll let you know if the issue still persists after deployment

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix a type in a prop name #35622

If no regressions arise, payment will be issued on 2024-02-14. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hayata-suenaga] The PR that introduced the bug has been identified. Link to the PR:
• [@hayata-suenaga] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hayata-suenaga] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hayata-suenaga] Determine if we should create a regression test for this bug.
• [@hayata-suenaga] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ishpaul777]

No payment requires I was not invovled in the PR

[hayata-suenaga]

I'm assigning @s77rt here as they reviewed the PR. However, this issue is for the regression caused by another PR that @s77rt reviewed.

[s77rt]

• The PR that introduced the bug has been identified: [Wave 8] Ideal nav  #33280
• The offending PR has been commented on: [Wave 8] Ideal nav  #33280 (comment)
• A discussion in #expensify-bugs has been started: n/a
• Determine if we should create a regression test for this bug: No

[s77rt]

This can be closed