-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Android - It is impossible to scan the receipt with the camera, an error is displayed. #35640
fix: Android - It is impossible to scan the receipt with the camera, an error is displayed. #35640
Conversation
…an error is displayed. Signed-off-by: Krishna Gupta <[email protected]>
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Still need to work on this and clear some issues. |
@aldo-expensify @thesahindia, the implementation works fine on both android & ios devices but there is a minor issue in android, when the app doesn't have any input for the camera permissions from users and user goes to the scan tab, we show the default permissions alert, the default permission value is If we want to change this I can spend more time, but I already have spent more than enough time on this :) Android: android_native_2feb.mp4IOS: ios_native_2feb.mp4 |
@aldo-expensify @thesahindia, bump on the above question^ |
Sorry for the delay. I agree it's a minor issue. I am fine with it but let's wait for @aldo-expensify's opinion. |
Agree, it sounds like an issue coming from Android and I don't think it is worth it to try to go around it if it is too complicated. Just please leave a comment in the code saying that. |
@thesahindia, can you pls review this, all screenshots have been added. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-02-11.at.12.15.46.AM.movAndroid: mWeb ChromeScreen.Recording.2024-02-11.at.12.23.06.AM.moviOS: NativeScreen.Recording.2024-02-11.at.12.30.39.AM.moviOS: mWeb SafariScreen.Recording.2024-02-11.at.12.27.03.AM.movMacOS: Chrome / SafariScreen.Recording.2024-02-11.at.12.43.58.AM.movMacOS: DesktopScreen.Recording.2024-02-11.at.12.40.24.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Please address this @Krishna2323 |
Signed-off-by: Krishna Gupta <[email protected]>
Comment added. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.41-12 🚀
|
Details
Fixed Issues
$ #34750
PROPOSAL: #34750 (comment)
Tests
Prerequisites:
allow/don't allow
options on IOS and with 3 options in androiddon't allow
Capture
orContinue
button and a verify a modal opens which hassettings
option.Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android_native_2feb.mp4
Android: mWeb Chrome
android_chrome.mp4
iOS: Native
ios_native_2feb.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
web_chrome.mp4
MacOS: Desktop
desktop_app.mp4