[HOLD for payment 2024-02-26] [$250] Workspace switcher - No tooltip when hovering over + button next to Workspaces

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4-36.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open workspace switcher
2. Hover over + button next to Workspaces

Expected Result:

Tooltip will show up

Actual Result:

No tooltip when hovering over + button next to Workspaces

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365095_1706894912514.20240202_233253__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cb8f425174a88fd1
• Upwork Job ID: 1753484365389684736
• Last Price Increase: 2024-02-02
• Automatic offers:
• neonbhai | Contributor | 28142987

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @Quinter

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace switcher - No tooltip when hovering over + button next to Workspaces

What is the root cause of that problem?

We are missing the logic for showing a tooltip.

What changes do you think we should make in order to solve the problem?

We should wrap the icon here with Tooltip:

App/src/pages/WorkspaceSwitcherPage.tsx

Lines 215 to 231 in e6ea03b

	<PressableWithFeedback
	accessible={false}
	role={CONST.ROLE.BUTTON}
	onPress={() => {
	App.createWorkspaceWithPolicyDraftAndNavigateToIt();
	}}
	>
	{({hovered}) => (
	<Icon
	src={Expensicons.Plus}
	width={12}
	height={12}
	additionalStyles={[styles.buttonDefaultBG, styles.borderRadiusNormal, styles.p2, hovered && styles.buttonHoveredBG]}
	fill={theme.icon}
	/>
	)}
	</PressableWithFeedback>

<Tooltip text={translate('common.new')}>
...
</Tooltip>

[luacmartins]

I don't think this is a blocker. Added to the project board and gonna follow the regular process.

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cb8f425174a88fd1

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No tooltip when hovering over + button next to Workspaces

What is the root cause of that problem?

We don't have tooltip component over here Icon component

App/src/pages/WorkspaceSwitcherPage.tsx

Lines 223 to 229 in e6ea03b

	<Icon
	src={Expensicons.Plus}
	width={12}
	height={12}
	additionalStyles={[styles.buttonDefaultBG, styles.borderRadiusNormal, styles.p2, hovered && styles.buttonHoveredBG]}
	fill={theme.icon}
	/>

What changes do you think we should make in order to solve the problem?

wrap Icon with TootTip:

<Tooltip text={translate('workspace.new.newWorkspace')}>
..................
</Tooltip>

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Upwork job price has been updated to $250

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace switcher - No tooltip when hovering over + button next to Workspaces

What is the root cause of that problem?

We don't wrap the icon with Tooltip component.

App/src/pages/WorkspaceSwitcherPage.tsx

Lines 223 to 229 in e6ea03b

	<Icon
	src={Expensicons.Plus}
	width={12}
	height={12}
	additionalStyles={[styles.buttonDefaultBG, styles.borderRadiusNormal, styles.p2, hovered && styles.buttonHoveredBG]}
	fill={theme.icon}
	/>

What changes do you think we should make in order to solve the problem?

We should wrap the PressableWithFeedback (parent component of icon) with tooltip and pass text={translate('workspace.new.newWorkspace')}.

We can also add tooltip for serach icon on the same page.

Result

[allgandalf]

Proposal Update:

Here

No major changes, just updated the text inside of the tooltip (Can check history too)

[Krishna2323]

@RohanSasne, you were referring to wrong tooltip text before my proposal.

[allgandalf]

Yes that's why i posted the updated proposal comment @Krishna2323 :)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Workspace] Fix tooltip for new workspace button #36100

If no regressions arise, payment will be issued on 2024-02-26. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @neonbhai requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rushatgabhane]

@slafortune could you please attach payment summary for this issue, thanks 🙇

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: [Wave 8] Ideal nav  #33280

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/33280/files#r1516865375

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

4. Determine if we should create a regression test for this bug. - No.

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

[rushatgabhane]

money request here - https://staging.new.expensify.com/r/2759990158891514

[slafortune]

Waiting on @rushatgabhane to complete the checklist -

• @rushatgabhane requires payment through NewDot Manual Requests - $250
• @neonbhai pay $250 via Upworks - PAID

[melvin-bot]

@slafortune, @luacmartins, @rushatgabhane, @neonbhai Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[slafortune]

Waiting on @rushatgabhane to complete the checklist

[luacmartins]

same as above

[JmillsExpensify]

$250 approved for @rushatgabhane based on this summary.

[slafortune]

@rushatgabhane will you be able to complete the checklist today? Seems like it will be pretty straight forward?

[luacmartins]

Still waiting on payments

[slafortune]

@rushatgabhane needs to complete the checklist -payments have all been made.

[rushatgabhane]

checklist updated - #35683 (comment)