Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD 35626][$500] Chat - User redirected to LHN instead of chat after going back from task #35697

Closed
3 of 6 tasks
lanitochka17 opened this issue Feb 2, 2024 · 11 comments
Closed
3 of 6 tasks
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 2, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.36
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Open the app and log in
  2. Navigate to any chat
  3. Tap "+" > "Assign task"
  4. Create a task
  5. Open the task from the chat history
  6. Tap the back icon

Expected Result:

User is returned to the chat where the task was created

Actual Result:

User is redirected to LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365163_1706897741164.video_2024-02-02_13-14-58.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014da3b04c59616570
  • Upwork Job ID: 1753490177126359040
  • Last Price Increase: 2024-02-02
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Feb 2, 2024
Copy link
Contributor

github-actions bot commented Feb 2, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 2, 2024

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp
CC @quinthar

@neil-marcellini
Copy link
Contributor

I would guess that this is related to [Wave 8] Ideal nav #33280, but I'll have to confirm. I doubt we want to revert that since it's such a large PR, so let's see if we can find the fix. Assigning external for additional help as I investigate.

@neil-marcellini neil-marcellini added the External Added to denote the issue can be worked on by a contributor label Feb 2, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

Job added to Upwork: https://www.upwork.com/jobs/~014da3b04c59616570

@melvin-bot melvin-bot bot changed the title Chat - User redirected to LHN instead of chat after going back from task [$500] Chat - User redirected to LHN instead of chat after going back from task Feb 2, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 2, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

@thienlnam
Copy link
Contributor

Looks related to all these other .goBack bugs which I believe is being handled by @adamgrzybowski https://expensify.slack.com/archives/C01GTK53T8Q/p1706830933437469?thread_ts=1706829675.205549&cid=C01GTK53T8Q

@neil-marcellini
Copy link
Contributor

This is already being tracked with this issue [Wave 8] [Ideal Nav] Back navigation issues, so I'm going to remove the blocker label and hold it on that issue.

@neil-marcellini neil-marcellini removed the DeployBlockerCash This issue or pull request should block deployment label Feb 2, 2024
@neil-marcellini neil-marcellini changed the title [$500] Chat - User redirected to LHN instead of chat after going back from task [HOLD 35626][$500] Chat - User redirected to LHN instead of chat after going back from task Feb 2, 2024
@neil-marcellini neil-marcellini added Weekly KSv2 and removed Hourly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Feb 2, 2024
@hayata-suenaga
Copy link
Contributor

Yes we can close this issue as the regression is already tracked 🙇

This comment was marked as off-topic.

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants