Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAID] [$500] [Simplified Collect][Members] WorkspaceInvitePage: Redesign and scrolling to the first invited member #35717

Closed
luacmartins opened this issue Feb 2, 2024 · 56 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Feb 2, 2024

Implement WorkspaceInvitePage: Redesign and scrolling to the first invited member from the Simplified Collect: Profile, Members, Categories design doc

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f4ddf9c90431aacf
  • Upwork Job ID: 1755658647575998464
  • Last Price Increase: 2024-02-08
Issue OwnerCurrent Issue Owner: @strepanier03
Copy link

melvin-bot bot commented Feb 2, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 2, 2024
@luacmartins luacmartins moved this to Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) in [#whatsnext] Wave 08 - Collect Plan Admins Feb 2, 2024
@luacmartins
Copy link
Contributor Author

@burczu can you please comment here so I can assign you to the issue?

@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Feb 2, 2024
@luacmartins luacmartins changed the title [Simplified Collect] [Members] WorkspaceInvitePage: Redesign and scrolling to the first invited member [Simplified Collect][Members] WorkspaceInvitePage: Redesign and scrolling to the first invited member Feb 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 5, 2024
@burczu
Copy link
Contributor

burczu commented Feb 5, 2024

Hi! I'm Bartek from Callstack - expert contributor group. I'll work on this issue so please assign me. Thank you.

Copy link

melvin-bot bot commented Feb 8, 2024

@burczu, @strepanier03, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Feb 8, 2024
@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Feb 8, 2024
Copy link

melvin-bot bot commented Feb 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01f4ddf9c90431aacf

@melvin-bot melvin-bot bot changed the title [Simplified Collect][Members] WorkspaceInvitePage: Redesign and scrolling to the first invited member [$500] [Simplified Collect][Members] WorkspaceInvitePage: Redesign and scrolling to the first invited member Feb 8, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 8, 2024
Copy link

melvin-bot bot commented Feb 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

@melvin-bot melvin-bot bot removed the Overdue label Feb 8, 2024
@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 8, 2024
@ishpaul777
Copy link
Contributor

hii @luacmartins @trjExpensify, I requested access to design doc to get some context for the issue but it got declined, can you please add some context in issue description if design doc is internal only. Thanks!

@trjExpensify
Copy link
Contributor

Yeah, I don't think we can share design docs without an NDA in place. We could do that, I guess? But TL;DR from a high level on this portion.

  • Post-invite, the admin lands back on the members page, with the table scrolled to the first user added (if multiple were added simultaneously) such that the newly added member is in the scroll view. The row is temporarily highlighted to confirm that the invite was successful.
    • Note: This same pattern will be used throughout the workspace, specifically any time that a new value or member is added to a table.
    • Note: if multiple members are added, all will be highlighted, and we’ll scroll the position of the first one invited.

Copy link

melvin-bot bot commented Mar 15, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-22. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Mar 15, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

@mountiny
Copy link
Contributor

I think that will be $500 to @shubham1206agra and to @ishpaul777

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Mar 18, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-03-22] [$500] [Simplified Collect][Members] WorkspaceInvitePage: Redesign and scrolling to the first invited member [HOLD for payment 2024-03-25] [HOLD for payment 2024-03-22] [$500] [Simplified Collect][Members] WorkspaceInvitePage: Redesign and scrolling to the first invited member Mar 18, 2024
Copy link

melvin-bot bot commented Mar 18, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-25. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Mar 18, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

@strepanier03 strepanier03 added Daily KSv2 and removed Weekly KSv2 labels Mar 25, 2024
@strepanier03
Copy link
Contributor

@ishpaul777 and @shubham1206agra - I'll send over offers now, but will hold on payment until the BZ checklist is done. If we don't need a reg test then just confirm for me here and I'll skip holding payment until that's done.

@strepanier03
Copy link
Contributor

All right, invites sent. I'll check back later today and tomorrow.

@ishpaul777
Copy link
Contributor

No regression test needed this was a new feature

Can we please hold the payment for few days,I have applied GSTIN which will take few days otherwise upwork keeps charging me extra 💰 https://support.upwork.com/hc/en-us/articles/360041114713-India-GST-for-freelancers

@shubham1206agra
Copy link
Contributor

@strepanier03 Actually, I have my payment on hold due to some issues.

@shubham1206agra
Copy link
Contributor

@strepanier03 I have discussed this internally here. You may close this issue as I am keeping track of payment internally and will ask to pay once the issue is resolved. Just write in the payment summary that I have not been paid yet.

@strepanier03
Copy link
Contributor

Payment Summary

Per the comment above and the linked Slack thread, I'm closing this with the above payment summary.

@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Mar 27, 2024
@ishpaul777
Copy link
Contributor

hey @strepanier03, Thanks for holding. Can we reopen and process the payment now

@shubham1206agra
Copy link
Contributor

@strepanier03 You can process payment here now.

@strepanier03 strepanier03 reopened this Apr 23, 2024
@strepanier03
Copy link
Contributor

I've hired you both the job in Upwork. I'll keep an eye out for you to accept and then I'll handle payment and close contracts. Thank you both @shubham1206agra and @ishpaul777.

@shubham1206agra
Copy link
Contributor

@strepanier03 Accepted

@ishpaul777
Copy link
Contributor

Accepted!

@strepanier03
Copy link
Contributor

Great, finishing up now. Thanks!

@strepanier03
Copy link
Contributor

Both contracts are paid and closed. Cheers everyone!

@strepanier03 strepanier03 changed the title [HOLD for payment 2024-03-25] [HOLD for payment 2024-03-22] [$500] [Simplified Collect][Members] WorkspaceInvitePage: Redesign and scrolling to the first invited member [PAID] [$500] [Simplified Collect][Members] WorkspaceInvitePage: Redesign and scrolling to the first invited member Apr 23, 2024
@ishpaul777
Copy link
Contributor

Hey @strepanier03 I think you forgot to release the payment on upwork for this job,

offer - https://www.upwork.com/nx/wm/offer/101593932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Status: Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals)
Development

No branches or pull requests

8 participants