Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold for #38025] [$1000] Chat - Email id not shown in full available space & after sending full email iID shown for public accounts #35725

Open
3 of 6 tasks
kbecciv opened this issue Feb 2, 2024 · 111 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Feb 2, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.36
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Launch app
  2. Tap in a report
  3. Enter @ in compose box
  4. Select an user from suggestions list
  5. Note email id is not displayed occupying full space
  6. Send the message

Expected Result:

After selecting an email ID from the user suggestion list, it should be displayed in full within the available space. Once sent, the full email ID should not be displayed.

Actual Result:

The selected email id from user suggestion list is not shown in full available space and after sending full email id is displayed.The selected email ID from the user suggestion list is not displayed in full within the available space. Additionally, after sending, the full email ID is still displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365262_1706904011478.az_recorder_20240202_215806.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015976cfa3c5a4e481
  • Upwork Job ID: 1753528802729029632
  • Last Price Increase: 2024-03-07
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 2, 2024
@melvin-bot melvin-bot bot changed the title Chat - Email id not shown in full available space & after sending full email iID shown for public accounts [$500] Chat - Email id not shown in full available space & after sending full email iID shown for public accounts Feb 2, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

Job added to Upwork: https://www.upwork.com/jobs/~015976cfa3c5a4e481

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 2, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

Copy link

melvin-bot bot commented Feb 2, 2024

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@kbecciv
Copy link
Author

kbecciv commented Feb 2, 2024

We think that this bug might be related to #vip-vsb
CC @quinthar

@MitchExpensify
Copy link
Contributor

I am having trouble understanding this bug. Can you please rephrase the expected and actual results @kbecciv?

@melvin-bot melvin-bot bot added the Overdue label Feb 6, 2024
@Santhosh-Sellavel
Copy link
Collaborator

Screenshot 2024-02-07 at 2 15 34 AM

@MitchExpensify
Check the above screenshot taken from the issue description.

Bug 1

In the composer box email is broken into multiple lines due to a long email, but still, some space on the right side is there.

The same email uses the full available space after sending it in the message area
Screenshot 2024-02-07 at 2 18 06 AM

Bug 2

Additionally, after sending, the full email ID is still displayed

I don't get this properly. But I guess
After selecting a user for mentioning from the suggested options, the message should have had the user name in the message instead of the email ID if the user name is available.

Example @Mitch instead [email protected]

Can you confirm @kbecciv ?

@melvin-bot melvin-bot bot removed the Overdue label Feb 6, 2024
@kbecciv
Copy link
Author

kbecciv commented Feb 8, 2024

Yes, correct! @Santhosh-Sellavel

Copy link

melvin-bot bot commented Feb 9, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Feb 9, 2024
Copy link

melvin-bot bot commented Feb 12, 2024

@MitchExpensify, @Santhosh-Sellavel Huh... This is 4 days overdue. Who can take care of this?

@Santhosh-Sellavel
Copy link
Collaborator

Bump @MitchExpensify

@melvin-bot melvin-bot bot removed the Overdue label Feb 12, 2024
@Santhosh-Sellavel
Copy link
Collaborator

Santhosh-Sellavel commented Feb 13, 2024

We are still waiting for a confirmation from @MitchExpensify to move forward and proposals as well.
Unassigning as am planning for OOO, please assign a new C+ once we decide to move forward!

@Santhosh-Sellavel Santhosh-Sellavel removed their assignment Feb 13, 2024
@MitchExpensify
Copy link
Contributor

MitchExpensify commented Feb 15, 2024

Ok got it! Yes lets fix this. I think it could fit in #vip-vsb cc @quinthar

Copy link

melvin-bot bot commented Feb 16, 2024

@MitchExpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Feb 16, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2024
@Victor-Nyagudi
Copy link
Contributor

Victor-Nyagudi commented Feb 20, 2024

I could reproduce this yesterday, but I'm no longer able to after merging main, even though I'm not entirely confident doing so is what fixed it.

I'll explain why in a little bit.

Firstly, everything worked fine to begin with on Android Web.

Android Chrome screenshots

Screenshot_20240219_105406_Chrome.jpg

Screenshot_20240219_105529_Chrome.jpg

Screenshot_20240219_105157_Chrome.jpg

Secondly, I noticed that the reason the text got formatted incorrectly is that the input started with an @ sign followed by some characters that extended to the next line and then a period in between.

This is what happens when you mention a user with a very long email address.

Here's the video I recorded yesterday.

Previous bug recording
XRecorder_19022024_122342.mp4

I did some digging and decided to test this assumption using the React Native docs' Expo playground a couple of minutes ago.

The results confirmed my suspicions, and in addition, the bug occurred with a couple of other characters too.

Expo playground results
expensify-android-input-bug-expo.mp4

I checked the React Native issues but didn't find anything reported on this behavior.

I believe this could be a bug in the TextInput on Android.

I haven't opened an issue yet on the React Native repo.

Copy link

melvin-bot bot commented Feb 20, 2024

@MitchExpensify Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Feb 22, 2024

@MitchExpensify Still overdue 6 days?! Let's take care of this!

@lschurr
Copy link
Contributor

lschurr commented Oct 25, 2024

Hold

@melvin-bot melvin-bot bot removed the Overdue label Oct 25, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 4, 2024
@lschurr
Copy link
Contributor

lschurr commented Nov 4, 2024

On hold

@melvin-bot melvin-bot bot removed the Overdue label Nov 4, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 13, 2024
@lschurr
Copy link
Contributor

lschurr commented Nov 13, 2024

On hold

@melvin-bot melvin-bot bot removed the Overdue label Nov 13, 2024
@twisterdotcom twisterdotcom removed the Bug Something is broken. Auto assigns a BugZero manager. label Nov 18, 2024
@twisterdotcom
Copy link
Contributor

Relabelling as Lauren is OOO now.

@twisterdotcom twisterdotcom added the Bug Something is broken. Auto assigns a BugZero manager. label Nov 18, 2024
Copy link

melvin-bot bot commented Nov 18, 2024

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Nov 18, 2024
@CortneyOfstad
Copy link
Contributor

Still on-hold 👍

@melvin-bot melvin-bot bot removed the Overdue label Nov 21, 2024
@CortneyOfstad CortneyOfstad added Weekly KSv2 and removed Daily KSv2 labels Nov 21, 2024
@CortneyOfstad
Copy link
Contributor

Still on hold — #38025

@CortneyOfstad
Copy link
Contributor

@lschurr is back in office, so unassigning myself. Thanks!

@lschurr
Copy link
Contributor

lschurr commented Dec 12, 2024

On hold

@melvin-bot melvin-bot bot removed the Overdue label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Development

No branches or pull requests