[$500] Workspace switcher - Search result is not highlighted when navigating via up and down key

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.36.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Infernal team
Slack conversation:

Action Performed:

Precondition:

• There are more than 7 workspaces.
• App is in "Expensify" filter in the workspace switcher.

1. Go to staging.new.expensify.com
2. Open workspace switcher.
3. Click on the search bar.
4. Search for term that will return a few results.
5. Press up or down key on keyboard.

Expected Result:

The search result will be highlighted.

Actual Result:

The search result is not highlighted when navigating via up and down key.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365293_1706905907640.20240203_004235.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019e5fbb8f8bcace41
• Upwork Job ID: 1757911779125587968
• Last Price Increase: 2024-02-14
• Automatic offers:
• cubuspl42 | Reviewer | 0
• bernhardoj | Contributor | 0

Issue Owner

Current Issue Owner: @johncschuster

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #vip-vsb
CC @quinthar

[luacmartins]

I think we can demote this to NAB

[AndrewGable]

Demoted and I will let @quinthar find someone from VSB to pick this one up

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The workspace item doesn't gets highlighted when navigating with arrow key.

What is the root cause of that problem?

We disable the highlight/focus if there is no active workspace selected (Everything is selected).

App/src/pages/WorkspaceSwitcherPage.tsx

Line 250 in 3ab4e6e

disableFocusOptions={!activeWorkspaceID}

What changes do you think we should make in order to solve the problem?

If we want to enable the highlight, we can just remove disableFocusOptions.

[luacmartins]

I think this actually came from the #33280 PR.

[melvin-bot]

@AndrewGable Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@AndrewGable Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@AndrewGable 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@AndrewGable 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019e5fbb8f8bcace41

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[AndrewGable]

@cubuspl42 - Can we verify this still exists? Then otherwise we can evaluate @bernhardoj's proposal

[melvin-bot]

@iwiznia, @cubuspl42, @AndrewGable Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 @cubuspl42 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @cubuspl42

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[luacmartins]

Interesting, so the fix above wasn't necessary?

[bernhardoj]

Still happens on staging (the PR is not deployed to staging yet)

Screen.Recording.2024-02-22.at.12.27.57.mov

[melvin-bot]

This issue has not been updated in over 15 days. @iwiznia, @cubuspl42, @bernhardoj eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[cubuspl42]

Oh my, I'm out of the loop here. So it looks like we had a regression, but it already got fixed?

[bernhardoj]

Oh, I forget about this one too. There is no regression. It was a false alarm. So, this is ready for payment.

[cubuspl42]

@iwiznia Friendly bump 🙂

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[cubuspl42]

@johncschuster Friendly bump 🙂 As I understand it, we're ready for payments

• $500 for @bernhardoj
• $500 for me

[johncschuster]

Payment has been issued! 🎉