Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [MEDIUM] IOU - Report fields are blank after refresh or leave from report #35772

Closed
3 of 6 tasks
lanitochka17 opened this issue Feb 4, 2024 · 15 comments
Closed
3 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 4, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.36-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #34483

Action Performed:

  1. In Old dot, create a new Collect / Control policy
  2. Go to the settings of this workspace and execute the following in console:
    p = Policy.getCurrent();
    p.policy.isPolicyExpenseChatEnabled = "true";
    p.save();
  3. Go to the reports section of the settings of the newly create workspace and add some report fields
  4. Invite a user to be a member of this new workspace
  5. In NewDot, login as the invited user. Make sure canUseReportFields beta is enabled for the user
  6. Go to the workspace chat room and request some money
  7. Open the created expense report
  8. Verify that the custom fields show up
  9. Click on each of the field
  10. Enter a value and save it

Expected Result:

Make sure that the field gets saved successfully and you can submit report

Actual Result:

When leaving and re-entering the report the fields have been cleared, it also happens after refreshing
Report present error after you try to submit

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6366369_1707000347908.PR_34483_Web.mp4
Bug6366369_1707000347888.PR_34483_Mweb.mp4
Bug6366369_1707000347888.PR_34483_Mweb.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017fe95e1509261ee2
  • Upwork Job ID: 1754149879851364352
  • Last Price Increase: 2024-02-11
@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 4, 2024
@melvin-bot melvin-bot bot changed the title IOU - Report fields are blank after refresh or leave from report [$500] IOU - Report fields are blank after refresh or leave from report Feb 4, 2024
Copy link

melvin-bot bot commented Feb 4, 2024

Job added to Upwork: https://www.upwork.com/jobs/~017fe95e1509261ee2

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 4, 2024
Copy link

melvin-bot bot commented Feb 4, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

Copy link

melvin-bot bot commented Feb 4, 2024

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@stephanieelliott
Copy link
Contributor

Repro steps are clear and this seems like something that should be fixed. Let's wait for some proposals.

@HezekielT
Copy link
Contributor

I think this is a backend issue. The OpenReport api call is returning null for the report field's value which is why the fields are cleared.

@melvin-bot melvin-bot bot added the Overdue label Feb 8, 2024
@getusha
Copy link
Contributor

getusha commented Feb 8, 2024

Thanks @HezekielT
@stephanieelliott could we get internal engineer on this?

@melvin-bot melvin-bot bot removed the Overdue label Feb 8, 2024
@stephanieelliott
Copy link
Contributor

I think this should be tackled as part of Wave 6, posted to get confirmation here as a first step to try and source an internal engineer.

Copy link

melvin-bot bot commented Feb 11, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Feb 11, 2024
Copy link

melvin-bot bot commented Feb 12, 2024

@stephanieelliott, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

@getusha
Copy link
Contributor

getusha commented Feb 12, 2024

backend issue

@melvin-bot melvin-bot bot removed the Overdue label Feb 12, 2024
@greg-schroeder greg-schroeder changed the title [$500] IOU - Report fields are blank after refresh or leave from report [$500] [MEDIUM] IOU - Report fields are blank after refresh or leave from report Feb 12, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 15, 2024
@stephanieelliott stephanieelliott added the Internal Requires API changes or must be handled by Expensify staff label Feb 16, 2024
Copy link

melvin-bot bot commented Feb 16, 2024

Current assignee @getusha is eligible for the Internal assigner, not assigning anyone new.

@stephanieelliott stephanieelliott removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Feb 16, 2024
@stephanieelliott
Copy link
Contributor

Hey @thienlnam I noticed you are working on a bunch of issues related to report fields -- any chance you have the bandwidth to grab this one too?

@melvin-bot melvin-bot bot removed the Overdue label Feb 16, 2024
@thienlnam
Copy link
Contributor

Yeah, I thought this was solved but I can take another look

@thienlnam thienlnam self-assigned this Feb 16, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 18, 2024
@stephanieelliott
Copy link
Contributor

Fix for this is on staging

@stephanieelliott
Copy link
Contributor

Solved internally, no C+ review on this one so no payment due

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

5 participants