[HOLD for payment 2024-02-20] [$500] IOU - From link in header show "IOU" instead of <User owes $XX> in request page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.36
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create new account
3. Search for user & navigate to 1:1 DM
4. Tap on + icon >> Request money
5. Create IOU request
6. Navigate to IOU request page

Expected Result:

From link in header should display <User owes $XX> in request page

Actual Result:

From link in header show "IOU" instead of <User owes $XX> in request page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6367161_1707089817998.iOS-Issue_repro.mp4

Bug6367161_1707089818020.Recording__53.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0144d7b31b30f3c313
• Upwork Job ID: 1754457125768007680
• Last Price Increase: 2024-02-05

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0144d7b31b30f3c313

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

We think that this bug might be related to #vip-vsb
CC @quinthar

[Julesssss]

Raised in Slack here. I'm going to remove the deploy blocker label as this is relatively minor and doesn't break the app in any way. We have 30/40 other deploy blockers to resolve today 😬.

I checked the checklist and codebase and couldn't locate an obvious PR that introduced this, so we'll get this resolved as a typical external issue in the meantime.

[salmannotkhan]

@izarutskaya cannot reproduce the bug. I am able to see <User owes $XX>.

[melvin-bot]

📣 @salmannotkhan! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[salmannotkhan]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/salmannotkhan

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[Julesssss]

Thanks @salmannotkhan .

That's odd, earlier today I could reproduce. But now I'm unable to either 😕

[Julesssss]

Okay, with a brand new user, I can reproduce. However, I need to confirm whether this behaviour is actually a desired change. Here's the internal Slack discussion

Report Page:

Request page:

[salmannotkhan]

I just created both users and it worked as expected. But there is some delay when new user logs in and the account details are set properly. Maybe that's causing this issue.

[trjExpensify]

Ah, but this isn't the free plan. These are off-workspace P2P requests between two members on an iou type report. Is the fix being applied to that report type?

[JmillsExpensify]

I agree that we should never show editable titles, whether off workspace or the Free plan. (Equally, the Free plan is being deprecated in the coming months, so ideally the logic is more tied to only showing customizable report titles on paid Group plans (eg Collect and Control).

[thienlnam]

Hmm yeah, I guess then we should update this in the FE to not override for IOU reports cc @allroundexperts

[Julesssss]

Thanks @thienlnam, let me know if I can help further with any reviews, ect

[thienlnam]

@allroundexperts By the way, I'm going to update the BE so that openReport does not send back reportFields for any report type except expense reports right now. I think that should also solve things so that they do not need to be updated on the FE

[allroundexperts]

@thienlnam PR created for enabling this on paid workspaces only.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: enable report fields on paid workspaces only #36044

If no regressions arise, payment will be issued on 2024-02-20. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: feat: Integrate report fields with backend #34483
• The offending PR has been commented on: Not needed since the author fixed the bug
• A discussion in #expensify-bugs has been started: Not needed (a unique bug)
• Determine if we should create a regression test for this bug: Given that free policies are being deprecated, we won't need a regression test

[abekkala]

PAYMENT SUMMARY FOR FEB 20

• Issue reported by: Applause-Internal Team
• Fix: @allroundexperts [$500 - pending no regressions] Request Payment in NewDot
• PR Review: @s77rt [$500 - pending no regressions] Offer Link

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @s77rt paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@abekkala)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1754457125768007680/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[abekkala]

@s77rt payment was sent and contract ended - thank you! 🎉

[abekkala]

NewDot Payment Summary:

• Fix: @allroundexperts [$500] Request Payment in NewDot

[JmillsExpensify]

$500 approved for @allroundexperts based on summary above.