Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Needs repro] [LOW] [Splits] [$500] Split bill – Receipt missing details when create a Split bill with 2 new users #35925

Closed
1 of 6 tasks
lanitochka17 opened this issue Feb 6, 2024 · 62 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Needs Reproduction Reproducible steps needed

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 6, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.37-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4282722
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Login
  3. Click on the FAB button > Request money
  4. On the scan option, upload a digital receipt that will not fail the scan
  5. On the participant selection list, select 2 other participants that you don't have a group created already
  6. Continue to the final review page
  7. Enter a description and click save button
  8. Wait when Smartscan is complete
  9. Click on the split preview

Expected Result:

The amount and merchant fields are updated

Actual Result:

Red dot and Receipt missing details message appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6369554_1707238216624.Receipt_missing_details_when_create_a_Split_bill.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01927251e8dbd3f4a1
  • Upwork Job ID: 1754917730756308992
  • Last Price Increase: 2024-03-23
  • Automatic offers:
    • akinwale | Reviewer | 0
@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 6, 2024
@melvin-bot melvin-bot bot changed the title Split bill – Receipt missing details when create a Split bill with 2 new users [$500] Split bill – Receipt missing details when create a Split bill with 2 new users Feb 6, 2024
Copy link

melvin-bot bot commented Feb 6, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01927251e8dbd3f4a1

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 6, 2024
Copy link

melvin-bot bot commented Feb 6, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

Copy link

melvin-bot bot commented Feb 6, 2024

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@JordanLevy19
Copy link

Proposal

Please re-state the problem that we are trying to solve in this issue.
The problem arises from the receipt scan not recognizing or correctly assigning the "amount" from a receipt image uploaded for splitting expenses, leading to transactions displaying a "Receipt missing details" message.

What is the root cause of that problem?
The root cause of the problem appears to be a bug within the SmartScan's data extraction process. Specifically, identifying and parsing the amount from the uploaded receipt images.

What changes do you think we should make in order to solve the problem?

Refine TransactionUtils.ts:

Update the hasMissingSmartscanFields function to more accurately identify missing or incorrectly scanned data fields. This function checks if the transaction has missing required fields, which directly impacts the error state in the UI.

function hasMissingSmartscanFields(transaction) { return transaction && hasReceipt(transaction) && !isDistanceRequest(transaction) && !isReceiptBeingScanned(transaction) && areRequiredFieldsEmpty(transaction); }

Provide Manual Amount Entry as Fallback in MoneyRequestPreview:

In the case of issues with the amount data, allow users to manually enter or correct the amount directly within the MoneyRequestPreview component. This could be implemented by introducing an input field

if (hasMissingSmartscanFields(transaction)) { return ( <InputField label={translate('iou.enterAmountManually')} defaultValue={displayAmount} onChangeText={(value) => updateTransactionAmount(transactionID, value)} /> ); }

@melvin-bot melvin-bot bot added the Overdue label Feb 9, 2024
@akinwale
Copy link
Contributor

Still looking for proposals here.

@melvin-bot melvin-bot bot removed the Overdue label Feb 12, 2024
Copy link

melvin-bot bot commented Feb 13, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@strepanier03 strepanier03 changed the title [$500] Split bill – Receipt missing details when create a Split bill with 2 new users [VIP-Split] [$500] Split bill – Receipt missing details when create a Split bill with 2 new users Feb 13, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 14, 2024
@strepanier03
Copy link
Contributor

All good Melvin, waiting on proposals or urgency to move forward.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 14, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

@akinwale @strepanier03 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Feb 20, 2024

@akinwale, @strepanier03 Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Feb 20, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@strepanier03
Copy link
Contributor

Proposals needed.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 20, 2024
@strepanier03
Copy link
Contributor

Waiting for proposals.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 23, 2024
@strepanier03
Copy link
Contributor

Waiting for proposals.

@strepanier03
Copy link
Contributor

I've had trouble reproducing the steps mentioned in the description given the method posted in the comments above (screenshot with just three 'fields' for smartscan) as it would just get stuck on the scan in progress when the steps and video evidence show/talk about smartscan actually finishing the job but the details would be missing.
This led me to believe that it would need a more regular looking document but that didn't work either.

Looks like I'm running into the same thing as @Swor71.

I'm going to test the opposite as well and update here.

@melvin-bot melvin-bot bot added the Overdue label Apr 15, 2024
@strepanier03
Copy link
Contributor

Hmmm, so after some additional testing I can confirm I get the same unending scan issue following the OP steps. If the chat already exists, then the SS finishes and things are fine. This seems like a completely separate issue though.

I'm going to raise this for some internal discussion.

@melvin-bot melvin-bot bot removed the Overdue label Apr 15, 2024
@strepanier03 strepanier03 changed the title [LOW] [Splits] [$500] Split bill – Receipt missing details when create a Split bill with 2 new users [Discuss] [LOW] [Splits] [$500] Split bill – Receipt missing details when create a Split bill with 2 new users Apr 15, 2024
@Swor71
Copy link
Contributor

Swor71 commented Apr 16, 2024

hey, yea just to double confirm, the same keeps happening to me, tested again today. If there is a chat created before, the receipt gets scanned, although as you can see in the screenshot I had the dollar sign there but it set PLN as the currency, not sure if that's a bug or just a limitation of the scanner feature.

image

Also, to observe this issue happening you can create a money request with a random email address (doesn't have to be two ppl), which suggests to me it might have something to do with the creation of optimistic, placeholder, user - something I've previously seen to cause problems when assigning tasks to new users, maybe that helps.

This, however seems like a separate issue altogether, thanks for raising this internally @strepanier03.

Just fyi I have been reassigned to a different project, currently awaiting the move so unfortunately I'm not sure how much I would be able to participate going further.

@melvin-bot melvin-bot bot added the Overdue label Apr 18, 2024
Copy link

melvin-bot bot commented Apr 19, 2024

@akinwale, @strepanier03, @Swor71 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@strepanier03
Copy link
Contributor

Thanks for the heads up @Swor71!

I expect to have an update next week.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 19, 2024
@strepanier03
Copy link
Contributor

No update yet, haven't been able to prioritize this yet.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 22, 2024
Copy link

melvin-bot bot commented Apr 26, 2024

@akinwale, @strepanier03, @Swor71 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@strepanier03
Copy link
Contributor

This is on me, still working on it.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 29, 2024
Copy link

melvin-bot bot commented May 3, 2024

@akinwale, @strepanier03, @Swor71 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@strepanier03
Copy link
Contributor

Nothing yet, sorry all.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 3, 2024
Copy link

melvin-bot bot commented May 7, 2024

@akinwale, @strepanier03, @Swor71 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@strepanier03
Copy link
Contributor

Retesting today after releases have happened.

@melvin-bot melvin-bot bot removed the Overdue label May 7, 2024
@strepanier03
Copy link
Contributor

strepanier03 commented May 9, 2024

Using the following receipt image, I was able to test this successfully and did not reproduce the issue.

The SmartScan took some time but it finished and there were no missing receipt details.

2024-05-07_12-34-02

@strepanier03 strepanier03 added the Needs Reproduction Reproducible steps needed label May 9, 2024
@strepanier03 strepanier03 changed the title [Discuss] [LOW] [Splits] [$500] Split bill – Receipt missing details when create a Split bill with 2 new users [Needs repro] [LOW] [Splits] [$500] Split bill – Receipt missing details when create a Split bill with 2 new users May 9, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

7 participants