-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Needs repro] [LOW] [Splits] [$500] Split bill – Receipt missing details when create a Split bill with 2 new users #35925
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01927251e8dbd3f4a1 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale ( |
Triggered auto assignment to @strepanier03 ( |
Proposal Please re-state the problem that we are trying to solve in this issue. What is the root cause of that problem? What changes do you think we should make in order to solve the problem? Refine TransactionUtils.ts: Update the hasMissingSmartscanFields function to more accurately identify missing or incorrectly scanned data fields. This function checks if the transaction has missing required fields, which directly impacts the error state in the UI.
Provide Manual Amount Entry as Fallback in MoneyRequestPreview: In the case of issues with the amount data, allow users to manually enter or correct the amount directly within the MoneyRequestPreview component. This could be implemented by introducing an input field
|
Still looking for proposals here. |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
All good Melvin, waiting on proposals or urgency to move forward. |
@akinwale @strepanier03 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
@akinwale, @strepanier03 Huh... This is 4 days overdue. Who can take care of this? |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Proposals needed. |
Waiting for proposals. |
Waiting for proposals. |
Looks like I'm running into the same thing as @Swor71. I'm going to test the opposite as well and update here. |
Hmmm, so after some additional testing I can confirm I get the same unending scan issue following the OP steps. If the chat already exists, then the SS finishes and things are fine. This seems like a completely separate issue though. I'm going to raise this for some internal discussion. |
hey, yea just to double confirm, the same keeps happening to me, tested again today. If there is a chat created before, the receipt gets scanned, although as you can see in the screenshot I had the dollar sign there but it set PLN as the currency, not sure if that's a bug or just a limitation of the scanner feature. Also, to observe this issue happening you can create a money request with a random email address (doesn't have to be two ppl), which suggests to me it might have something to do with the creation of optimistic, placeholder, user - something I've previously seen to cause problems when assigning tasks to new users, maybe that helps. This, however seems like a separate issue altogether, thanks for raising this internally @strepanier03. Just fyi I have been reassigned to a different project, currently awaiting the move so unfortunately I'm not sure how much I would be able to participate going further. |
@akinwale, @strepanier03, @Swor71 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Thanks for the heads up @Swor71! I expect to have an update next week. |
No update yet, haven't been able to prioritize this yet. |
@akinwale, @strepanier03, @Swor71 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
This is on me, still working on it. |
@akinwale, @strepanier03, @Swor71 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Nothing yet, sorry all. |
@akinwale, @strepanier03, @Swor71 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Retesting today after releases have happened. |
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.37-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4282722
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
The amount and merchant fields are updated
Actual Result:
Red dot and Receipt missing details message appears
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6369554_1707238216624.Receipt_missing_details_when_create_a_Split_bill.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: