[LOW] DeleteWorkspace doesn't use optimistic reportAction data

[roryabraham]

Coming from https://expensify.slack.com/archives/C035J5C9FAP/p1706800444942609...

Problem

When we delete a workspace in NewDot, we create an optimistic CLOSED reportAction on the policy rooms, policyExpenseChat, etc...

However, that optimistic reportActionID is not used by the back-end.

Solution

Update DeleteWorkspace to follow our offline-first patterns and accept the optimistic reportActionIDs of the CLOSED actions and use them when closing reports in the back-end.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0116862805e09bb850
• Upwork Job ID: 1754951538014932992
• Last Price Increase: 2024-02-06

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0116862805e09bb850

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @allroundexperts (Internal)

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[roryabraham]

@perunt can you help clarify that effect this has on the end-user?

[perunt]

Currently, it doesn't impact users as we filter out this type of action.
It is more important for Comment Linking as we need a proper message chain. But it also isn't a blocker, as the optimistic response can be temporarily removed.

[CortneyOfstad]

@roryabraham any update on @perunt's comment above? Thanks!

[CortneyOfstad]

Bump @roryabraham ^^^ thanks!

[CortneyOfstad]

Bump @roryabraham ^^^

[CortneyOfstad]

@roryabraham can you confirm that you saw @perunt's comment here? Thank you!

[roryabraham]

Sorry for the delays - I'm not assigned to this issue so it's not in my K2, and I got behind on my email inbox.

It seems like this is a lower priority issue, but still one that we should fix. Going to make this weekly and move it to LOW in Wave 6. It's internal so we'll just need an Expensify engineer with bandwidth to take this on. Hopefully it should be included in the daily/weekly breakdown for wave6 issues in the slack channel and get a volunteer before too long.

[roryabraham]

sorry, I know it has been a few weeks without updates here. In that time we landed comment linking and the new arch, and have had a number of urgent issues/fires that have consumed all my attention. Hopefully in a few days, things will settle down and I'll be able to make my rounds on internal issues where I need to actually complete some PRs. Hopefully I can have something by EOW or next week

[CortneyOfstad]

Sounds good — thanks @roryabraham!

[CortneyOfstad]

Hi @roryabraham! Just doing a check-in to see if we're still on track to have something by EOW? If not, do you think we should adjust the frequency to monthly? Just trying to gauge where we're at — thank you!

[CortneyOfstad]

Bump @roryabraham ^^^ Thanks!

[CortneyOfstad]

@roryabraham bump ^^^

[CortneyOfstad]

Changing this to monthly. @roryabraham feel free to adjust it if need-be 👍

[CortneyOfstad]

Not overdue!

[CortneyOfstad]

Still not overdue — low priority at this point!

[trjExpensify]

Is this issue needed anymore? 🤔 Just thinking we've moved to archiving reports using the isArchived rNVP, so wonder if this CLOSED action consideration is obsolete. CC: @srikarparsi for a second opinion.

[CortneyOfstad]

@srikarparsi interested to hear your opinion on this! If we feel this is not needed, we can definitely close! I wasn't aware of the change to use isArchived rNVP — sorry for missing that!

[srikarparsi]

We still need the closed action because that contains the archived reason we display in the footer.

I'll assign myself and if I have time to look into this next week I will.

[trjExpensify]

Gotcha, so what are the next steps here? It's a bit unclear, and what impact this is having, especially as it has been open since Feb.

[srikarparsi]

Impact:
Basically nothing I believe? @roryabraham correct me if I'm wrong though. It's just that in most places, we optimistically create a report action in the beginning and then use that in the backend. But for this, I believe we didn't follow that here.

Next steps:
We would need App, Web and Auth PRs to push and use the right reportActionIDs for this but it's nothing crazy. I just haven't had time to prioritize it over current issues.

[trjExpensify]

Alright, but I think if we follow that git blame trail it leads to this issue of Aldo's to address it, so I think this issue is a dupe and we should close it? https://github.com/Expensify/Expensify/issues/383435

[roryabraham]

Agree, this is a dupe of https://github.com/Expensify/Expensify/issues/383435. Or technically that one is a dupe of this one. Happy to close this one and let @aldo-expensify handle