[$500] IOS - Workspace - Default currency is ignored

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.37.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Create a workspace
2. Go offline
3. Create an IOU in a workspace chat with any currency that isn't the workspace default one
4. Open the IOU

Expected Result:

The total should be 0 until coming online and should be using the workspace default currency

Actual Result:

The total is displayed in the requested currency

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6369737_1707247431281.PDMA0839.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f233ce8cd32c5963
• Upwork Job ID: 1754967996431261696
• Last Price Increase: 2024-02-06

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f233ce8cd32c5963

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

We think that this bug might be related to #wave6
CC @greg-schroeder

[jacobkim9881]

It seems related to this issue

[agent3bood]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOS - Workspace - Default currency is ignored

What is the root cause of that problem?

When creating new request IOU.requestMoney, the function generates optimistic responses based on the provided currency and amount, those values will be updated by the server afterwards.
Generating optimistic data need to take into account the workspace currency in order to fix the issue.
This issue happens on all platforms, also another side effect of optimistic data even while online is when making a request with different currency the UI will show the request currency for a short period before receiving the server response.

What changes do you think we should make in order to solve the problem?

Modify code in ReportUtils.buildOptimisticChatReport, ReportUtils.buildOptimisticExpenseReport, ReportUtils.buildOptimisticIOUReport, TransactionUtils.buildOptimisticTransaction to account for the possibility of changing currency.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[c3024]

@alexpensify This is expected behaviour and introduced in #33171 and discussed on Slack as well. This issue can be closed.

[alexpensify]

@c3024 - thanks for flagging! I'm going to close now.