Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] IOU - Preview not shown as Paid if paid while user offline and attempted to delete it #36049

Closed
1 of 6 tasks
m-natarajan opened this issue Feb 7, 2024 · 16 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@m-natarajan
Copy link

m-natarajan commented Feb 7, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.38-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. [User A] Request money from User B
  2. [User A] Go to IOU report
  3. [User A] Go offline
  4. [User B] Pay the request
  5. [User A] Delete the request while offline and stay in the main chat
  6. [User A] Go online
  7. [User A] Verify the preview updates

Expected Result:

IOU preview in 1:1 chat should be updated and shown as paid with green checkmark.

Actual Result:

IOU preview is shown as unpaid, does not update until you tap on it.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6370625_1707324500147.Ayvg3946.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0131dfe6b91030d1b0
  • Upwork Job ID: 1755277772775849984
  • Last Price Increase: 2024-02-07
  • Automatic offers:
    • Ollyws | Reviewer | 0
@m-natarajan m-natarajan added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 7, 2024
@melvin-bot melvin-bot bot changed the title IOU - Preview not shown as Paid if paid while user offline and attempted to delete it [$500] IOU - Preview not shown as Paid if paid while user offline and attempted to delete it Feb 7, 2024
Copy link

melvin-bot bot commented Feb 7, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0131dfe6b91030d1b0

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 7, 2024
Copy link

melvin-bot bot commented Feb 7, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

Copy link

melvin-bot bot commented Feb 7, 2024

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@m-natarajan
Copy link
Author

We think that this bug might be related #vip-bills
CC @davidcardoza

@MitchExpensify
Copy link
Contributor

Reproduced, seems also potentially wave 5 worthy as a bug in the core request flow

@rezkiy37
Copy link
Contributor

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

@Ollyws
Copy link
Contributor

Ollyws commented Feb 12, 2024

Go ahead @rezkiy37
🎀👀🎀 C+ reviewed

Copy link

melvin-bot bot commented Feb 12, 2024

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 12, 2024
Copy link

melvin-bot bot commented Feb 12, 2024

📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@rezkiy37
Copy link
Contributor

rezkiy37 commented Feb 13, 2024

So, I've investigated the problem. Actually, looks like there is a small miscommunication between the backend and the app. For this logic to notify the app and send the latest changes, we use the Pusher. It works properly all the time, except one scenario. When the app goes offline, then back online, there is a period for a reconnection. Once the app has connected again successfully and even received other kind of messages, this update for a money request preview is missed. Looks like the Pusher sent it before, but the app was offline. As I understand there is no logic to sync data one more time. Anyway, we need to ask a backend developer, to clarify this.

IOS.mp4

@melvin-bot melvin-bot bot added the Overdue label Feb 15, 2024
Copy link

melvin-bot bot commented Feb 16, 2024

@Ollyws, @thienlnam, @MitchExpensify, @rezkiy37 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@MitchExpensify
Copy link
Contributor

@thienlnam what is your take on @rezkiy37 's backend related observation ?

@melvin-bot melvin-bot bot removed the Overdue label Feb 16, 2024
@thienlnam
Copy link
Contributor

That's a problem we're solving with our own onyx update events - where each separate device's updates are stored and delivered once the device is online. I imagine this scenario is one that would be fixed once we eventually migrate it over to our own onyx updates.

What API command is being called here?

@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2024
@rezkiy37
Copy link
Contributor

What API command is being called here?

The app calls a "RequestMoney" command to request an IOU.

Copy link

melvin-bot bot commented Feb 21, 2024

@Ollyws @thienlnam @MitchExpensify @rezkiy37 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@thienlnam
Copy link
Contributor

I looked at the video, and it seems like this will likely get handled once we eventually migrate RequestMoney to send pusher updates via Auth.

Additionally, considering how specific this bug is - I don't think we need to address it right now. It does inform the user correctly that they were unable to delete the request

cc @MitchExpensify Thoughts on closing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Status: Done
Development

No branches or pull requests

5 participants