-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] IOU - Preview not shown as Paid if paid while user offline and attempted to delete it #36049
Comments
Job added to Upwork: https://www.upwork.com/jobs/~0131dfe6b91030d1b0 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws ( |
Triggered auto assignment to @MitchExpensify ( |
We think that this bug might be related #vip-bills |
Reproduced, seems also potentially wave 5 worthy as a bug in the core request flow |
Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue. |
Go ahead @rezkiy37 |
Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
So, I've investigated the problem. Actually, looks like there is a small miscommunication between the backend and the app. For this logic to notify the app and send the latest changes, we use the Pusher. It works properly all the time, except one scenario. When the app goes offline, then back online, there is a period for a reconnection. Once the app has connected again successfully and even received other kind of messages, this update for a money request preview is missed. Looks like the Pusher sent it before, but the app was offline. As I understand there is no logic to sync data one more time. Anyway, we need to ask a backend developer, to clarify this. IOS.mp4 |
@Ollyws, @thienlnam, @MitchExpensify, @rezkiy37 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@thienlnam what is your take on @rezkiy37 's backend related observation ? |
That's a problem we're solving with our own onyx update events - where each separate device's updates are stored and delivered once the device is online. I imagine this scenario is one that would be fixed once we eventually migrate it over to our own onyx updates. What API command is being called here? |
The app calls a "RequestMoney" command to request an IOU. |
@Ollyws @thienlnam @MitchExpensify @rezkiy37 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
I looked at the video, and it seems like this will likely get handled once we eventually migrate RequestMoney to send pusher updates via Auth. Additionally, considering how specific this bug is - I don't think we need to address it right now. It does inform the user correctly that they were unable to delete the request cc @MitchExpensify Thoughts on closing this? |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.38-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Expected Result:
IOU preview in 1:1 chat should be updated and shown as paid with green checkmark.
Actual Result:
IOU preview is shown as unpaid, does not update until you tap on it.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6370625_1707324500147.Ayvg3946.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: