[$500] Thread - Copy link of parent message & tap on link, parent message is not highlighted

[lanitochka17]

HOLD on #30269

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.38
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on a report
3. Send the message
4. Long press and copy link
5. Paste it in compose and send the message
6. Tap on the link
7. Note the message is highlighted
8. Long press the message and select reply in thread
9. Send a reply
10. Long press parent message and copy link
11. Paste it in compose and send the message
    12.Tap on the link
12. Note the parent message is not highlighted

Expected Result:

In thread page, copy link of parent message and tap on link, parent message must be highlighted

Actual Result:

In thread page, copy link of parent message and tap on link, parent message is not highlighted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6370728_1707329622189.req.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ed16923747a7ed62
• Upwork Job ID: 1755300519347654656
• Last Price Increase: 2024-04-15
• Automatic offers:
• FitseTLT | Contributor | 0
• abdulrahuman5196 | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ed16923747a7ed62

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread - Copy link of parent message & tap on link, parent message is not highlighted

What is the root cause of that problem?

We haven't passed linkedReportActionID for ReportActionItemParentAction
as in here

App/src/pages/home/report/ReportActionsListItemRenderer.js

Lines 134 to 135 in f6ba751

	linkedReportActionID={linkedReportActionID}
	displayAsGroup={displayAsGroup}

What changes do you think we should make in order to solve the problem?

We should pass linkedReportActionID for ReportActionItemParentAction here

App/src/pages/home/report/ReportActionsListItemRenderer.js

Lines 124 to 127 in f6ba751

	<ReportActionItemParentAction
	shouldHideThreadDividerLine={shouldDisplayParentAction && shouldHideThreadDividerLine}
	reportID={report.reportID}
	index={index}

and then we should pass it to the ReportActionItem here too

App/src/pages/home/report/ReportActionItemParentAction.tsx

Lines 86 to 94 in f6ba751

	<ReportActionItem
	// @ts-expect-error TODO: Remove this once ReportActionItem (https://github.com/Expensify/App/issues/31982) is migrated to TypeScript.
	onPress={() => Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(ancestor.report.reportID))}
	report={ancestor.report}
	action={ancestor.reportAction}
	displayAsGroup={false}
	isMostRecentIOUReportAction={false}
	shouldDisplayNewMarker={ancestor.shouldDisplayNewMarker}
	index={index}

What alternative solutions did you explore? (Optional)

[trjExpensify]

Hm.. I don't see a Copy link menu item in the comment action menu. Leads me to think this might be new and related to comment linking, requiring a beta or something. CC: @roryabraham @marcaaron any ideas?

[roryabraham]

Yep, it's behind a beta. Putting this on HOLD for #30269

[trjExpensify]

Excellent, glad I asked! :)

[trjExpensify]

Still held on #30269

[situchan]

Same

[trjExpensify]

Still held on comment linking.

[trjExpensify]

Still held on comment linking.

[kavimuru]

Now we are seeing "Hmm it's not here" message appears.

ggm.mp4

[nkdengineer]

@roryabraham Do you have any feedback about comment and comment ?

[roryabraham]

What behavior is expected below?
We should navigate user to the parent report and highlight the parent message
User should stay in the thread report and hightlight the parent message
I wonder this because currently, in staging, when I click on the parent message in thread report, we are navigating user to parent report

I think the expected behavior is that we navigate the user to the parent report and highlight the parent message

[nkdengineer]

I have a proposal to fix it here. Should I re-post it in here as the issue #39737 is closed ?

[roryabraham]

we should create a new issue, I'll report it in #expensify-bugs

[nkdengineer]

we should create a new issue

We can re-open this #39737

[nkdengineer]

@roryabraham The PR #40344 can fix the bug #39737 so we do not need to reopen #39737

[melvin-bot]

This issue has not been updated in over 15 days. @trjExpensify, @FitseTLT, @abdulrahuman5196, @roryabraham eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[trjExpensify]

PR has conflicts, let's get those addressed and wrap this up next week!

[FitseTLT]

Yep @trjExpensify The conflictingPR has overlapped with ours and fixed it while our pr was on a review stage.

[trjExpensify]

Sorry, do you mind restating that?

[FitseTLT]

@trjExpensify The conflict you mentioned here was caused by a PR doing exactly what our pr (linked to this issue) was doing, so I had to close the pr.

[trjExpensify]

Oh, so if I'm following you, we can close this issue then right?

[FitseTLT]

Oh, so if I'm following you, we can close this issue then right?

Yep. We can close it but I had already raised the pr so payment is due.

[trjExpensify]

Alright, so I think we can pay 50% for the work completed to date.

[FitseTLT]

Alright, so I think we can pay 50% for the work completed to date.

Agree

[trjExpensify]

Cool, payment summary as follows:

• $250 to @FitseTLT for the partial PR
• $250 to @abdulrahuman5196 for the partial C+ review of the PR

Offers sent!

[FitseTLT]

offer Accepted @trjExpensify

[trjExpensify]

Settled up with you both, closing!