Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Not a Priority - Tasks] Task - Email of Hidden user is revealed in the task preview in search list #36060

Closed
6 tasks done
kbecciv opened this issue Feb 7, 2024 · 34 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Not a priority

Comments

@kbecciv
Copy link

kbecciv commented Feb 7, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v1.4.38-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

. Go to staging.new.expensify.com
2. Go to 1:1 DM with a Hidden user.
3. Create a task without assignee in the DM.
4. Open task thread.
5. Click Assignee and select the Hidden user as assignee.
6. Return to main chat and go to task thread again.
7. Open search list.

Expected Result:

The task preview in the search list will show "assigned to Hidden".

Actual Result:

The task preview in the search list shows "assigned to <full_email>" instead of "assigned to Hidden".

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6370774_1707331344358.bandicam_2024-02-07_23-45-40-856.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c4e0aec786beaff8
  • Upwork Job ID: 1755302591395364864
  • Last Price Increase: 2024-02-14
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 7, 2024
@melvin-bot melvin-bot bot changed the title Task - Email of Hidden user is revealed in the task preview in search list [$500] Task - Email of Hidden user is revealed in the task preview in search list Feb 7, 2024
Copy link

melvin-bot bot commented Feb 7, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01c4e0aec786beaff8

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 7, 2024
Copy link

melvin-bot bot commented Feb 7, 2024

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Feb 7, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@kbecciv
Copy link
Author

kbecciv commented Feb 7, 2024

We think that this bug might be related #vip-vsb
CC @quinthar

@Tony-MK
Copy link
Contributor

Tony-MK commented Feb 8, 2024

The root cause is the same as #35960.

The backend and frontend fixes should solve this issue as well.

@melvin-bot melvin-bot bot added the Overdue label Feb 12, 2024
@mananjadhav
Copy link
Collaborator

@s77rt Can you confirm if the linked issue fixes this one? If yes, then we can close this one out and update the issue description to add this one to the scope.

@melvin-bot melvin-bot bot removed the Overdue label Feb 12, 2024
@s77rt
Copy link
Contributor

s77rt commented Feb 12, 2024

@mananjadhav Yes looks same to me

@strepanier03
Copy link
Contributor

Should we close this one or leave it open on hold to check the issue is fixed from #36196?

@s77rt
Copy link
Contributor

s77rt commented Feb 13, 2024

Since editing the last message is intended the linked issue and PR won't fix this. I'm not sure about the expected behaviour here but I guess this need to be fixed in the BE.

@thienlnam If you assign a "Hidden" user should that user still stay hidden?

@thienlnam
Copy link
Contributor

Yeah it sounds like it - if you didn't have their personal details before assigning them then they shouldn't be revealed after getting assigned

Copy link

melvin-bot bot commented Feb 14, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Feb 15, 2024
@strepanier03
Copy link
Contributor

Aah so maybe this needs to be Internal then?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 16, 2024
Copy link

melvin-bot bot commented Feb 19, 2024

@mananjadhav, @strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@strepanier03 strepanier03 added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels Feb 20, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

Current assignee @mananjadhav is eligible for the Internal assigner, not assigning anyone new.

@strepanier03
Copy link
Contributor

Switched to Internal for a BE fix.

@melvin-bot melvin-bot bot removed the Overdue label Feb 20, 2024
@strepanier03 strepanier03 changed the title [Splits] [$500] Task - Email of Hidden user is revealed in the task preview in search list [Future] [Splits] [$500] Task - Email of Hidden user is revealed in the task preview in search list May 3, 2024
@melvin-bot melvin-bot bot added the Overdue label May 13, 2024
@mananjadhav
Copy link
Collaborator

Should we be putting this on Hold if not going to be prioritized?

@melvin-bot melvin-bot bot removed the Overdue label May 19, 2024
@melvin-bot melvin-bot bot added the Overdue label May 27, 2024
@mananjadhav
Copy link
Collaborator

@strepanier03 did you get a chance to look at my question?

@melvin-bot melvin-bot bot removed the Overdue label May 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 5, 2024
@strepanier03
Copy link
Contributor

@mananjadhav - Sorry for the hold up, I've been OoO and this hasn't been a priority. Seeing as VSB is pretty much on hold now, I think we can put it on hold for now.

@melvin-bot melvin-bot bot removed the Overdue label Jun 14, 2024
@strepanier03 strepanier03 changed the title [Future] [Splits] [$500] Task - Email of Hidden user is revealed in the task preview in search list [HOLD] [Future] [Splits] [$500] Task - Email of Hidden user is revealed in the task preview in search list Jun 14, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 24, 2024
@strepanier03
Copy link
Contributor

I'm setting monthly, this is on long term hold.

@melvin-bot melvin-bot bot removed the Overdue label Jun 26, 2024
@strepanier03 strepanier03 added Monthly KSv2 and removed Weekly KSv2 labels Jun 26, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 29, 2024
@strepanier03
Copy link
Contributor

On hold at this time.

@melvin-bot melvin-bot bot removed the Overdue label Jul 30, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 2, 2024
@strepanier03
Copy link
Contributor

Still held on prioritization.

@melvin-bot melvin-bot bot removed the Overdue label Sep 3, 2024
@mananjadhav
Copy link
Collaborator

@strepanier03 Any updates on this one?

@strepanier03
Copy link
Contributor

This is for Tasks and we're not actively working or developing them unless they affect the onboarding flow, this does not. I'm closing and making not a priority.

@melvin-bot melvin-bot bot removed the Overdue label Oct 30, 2024
@strepanier03 strepanier03 changed the title [HOLD] [Future] [Splits] [$500] Task - Email of Hidden user is revealed in the task preview in search list [Not a Priority - Tasks] Task - Email of Hidden user is revealed in the task preview in search list Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Not a priority
Projects
None yet
Development

No branches or pull requests

6 participants