[HOLD for payment 2024-03-11] [$500] Sign In - 'continue with the web app' link is not working on click

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.38.0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

1. Open desktop & navigate to log in page
2. Click on 'Sign in with Google' icon
3. Sign in with Google from browser
4. Click on 'Cancel' on the open desktop app prompt dialog box
5. Click on 'continue with the web app' link

Expected Result:

User should be signed in to browser

Actual Result:

The link is not working

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6371750_1707397032754.Screen_Recording_2024-02-07_at_11.47.44_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018b1482288004dd72
• Upwork Job ID: 1755578269220311040
• Last Price Increase: 2024-02-15
• Automatic offers:
• abdulrahuman5196 | Reviewer | 0
• bernhardoj | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018b1482288004dd72

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[izarutskaya]

We think that this bug might be related to #wave9-collect-signup
CC @MitchExpensify

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

continue with the web app' link is not working on click

What is the root cause of that problem?

We navigate to HOME on click to the link

App/src/components/DeeplinkWrapper/DeeplinkRedirectLoadingIndicator.tsx

Line 48 in caefc6e

{translate('deeplinkWrapper.or')} <TextLink onPress={() => Navigation.navigate(ROUTES.HOME)}>{translate('deeplinkWrapper.continueInWeb')}</TextLink>.

What changes do you think we should make in order to solve the problem?

Update the Navigation.navigate to reroute into browser

What alternative solutions did you explore? (Optional)

N/A

[allgandalf]

@izarutskaya , the bug video hasn't been uploaded yet, can you please update it :) thanks

[izarutskaya]

Sorry, I added it again

[DevOpsacmeuniverse]

Do I need to apply through upwork?

[melvin-bot]

📣 @DevOpsacmeuniverse! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[kevalacme]

HI

[melvin-bot]

📣 @kevalacme! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[kevalacme]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/agencies/599142969657077760/

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[kevalacme]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/fl/~01de57443ab6a9b794

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The 'continue with the web app' text link doesn't do anything.

What is the root cause of that problem?

The 'continue with the web app' link navigates to HOME.

App/src/components/DeeplinkWrapper/DeeplinkRedirectLoadingIndicator.tsx

Line 48 in c3ae221

{translate('deeplinkWrapper.or')} <TextLink onPress={() => Navigation.navigate(ROUTES.HOME)}>{translate('deeplinkWrapper.continueInWeb')}</TextLink>.

HOME is a bottom tab route screen and if the bottom tab action here is undefined, it returns early and does nothing.

App/src/libs/Navigation/linkTo.ts

Lines 203 to 210 in dafaf7f

	} else if (action.payload.name === NAVIGATORS.BOTTOM_TAB_NAVIGATOR) {
	// If path contains a policyID, we should invoke the navigate function
	const shouldNavigate = !!extractedPolicyID;
	const actionForBottomTabNavigator = getActionForBottomTabNavigator(action, rootState, policyID, shouldNavigate);
	if (!actionForBottomTabNavigator) {
	return;
	}

The action will be undefined if the bottom tab screen we are targeting is the same topmost bottom tab screen.

App/src/libs/Navigation/linkTo.ts

Lines 95 to 111 in c3ae221

	const bottomTabCurrentTab = getTopmostBottomTabRoute(state);
	const bottomTabParams = bottomTabCurrentTab?.params as Record<string, string | undefined>;
	// Verify if the policyID is different than the one we are currently on. If it is, we need to navigate to the new policyID.
	const isNewPolicy = bottomTabParams?.policyID !== payloadParams?.policyID;
	if (bottomTabCurrentTab?.name === screen && !shouldNavigate && !isNewPolicy) {
	return;
	}
	return {
	type: CONST.NAVIGATION.ACTION_TYPE.PUSH,
	payload: {
	name: screen,
	params: payloadParams,
	},
	target: bottomTabNavigatorRoute.state.key,
	};

After we log in, the topmost bottom tab screen is HOME, so when we try to navigate to HOME, it does nothing.

What changes do you think we should make in order to solve the problem?

Instead of navigating to HOME, we can just simply call goBack.

or dismissModal
or closeFullScreen which pops all screen but causes this issue

What alternative solutions did you explore? (Optional)

Instead of early return if the bottom tab screen target is the same, we can change the action type to NAVIGATE.

const actionType = (bottomTabCurrentTab?.name === screen && !shouldNavigate && !isNewPolicy) ? CONST.NAVIGATION.ACTION_TYPE.NAVIGATE : CONST.NAVIGATION.ACTION_TYPE.PUSH;

return {
    type: type: actionType,

but this will have the same effect as closeFullScreen

[jliexpensify]

Asking Mitch here - https://expensify.slack.com/archives/C05NJ4SLBMF/p1707437575132939

[jliexpensify]

@izarutskaya I understand that we had a SSO 🔥 earlier - can you re-test this and make sure the link still isn't working? I don't think this is related to the fire, but probably good to make sure!

[MitchExpensify]

@abdulrahuman5196 how does @bernhardoj 's proposal look to you?

[melvin-bot]

@jliexpensify, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[abdulrahuman5196]

Hi, Will work on review today.

[jliexpensify]

Bump @abdulrahuman5196 , have you reviewed the comments?

[abdulrahuman5196]

Reviewing now

[abdulrahuman5196]

@bernhardoj 's proposal here #36145 (comment) looks good and works well.

🎀 👀 🎀
C+ Reviewed

[melvin-bot]

Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@nkuoch @jliexpensify @abdulrahuman5196 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @abdulrahuman5196

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix can't close desktop sign in redirect page #37198

If no regressions arise, payment will be issued on 2024-03-11. 🎊

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment automatic offer (Reviewer)
• @bernhardoj requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Doesn't have regression PR directly. Could be cause of common navigation changes.

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Open desktop & navigate to log in page
2. Click on 'Sign in with Google' icon
3. Sign in with Google from browser
4. Click on 'Cancel' on the open desktop app prompt dialog box
5. Click on 'continue with the web app' link

[jliexpensify]

Payment Summary:

• C: @bernhardoj $500
• C+: @abdulrahuman5196 $500

Upwork job

[jliexpensify]

Paid and job closed.