Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD https://github.com/Expensify/react-native-live-markdown/pull/175]Web - Composer - Composer is highlighted but there is no Insertion Pointer ( | ) in composer #36172

Closed
1 of 6 tasks
kbecciv opened this issue Feb 8, 2024 · 12 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Feb 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v1.4.39-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Open ND
  2. Navigate between chats

Expected Result:

Insertion pointer should be displayed in composer

Actual Result:

Insertion pointer is not displayed in composer

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6372416_1707419546821.cursor.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented Feb 8, 2024

We think that this bug might be related #vip-vsb
CC @quinthar

Copy link

melvin-bot bot commented Feb 8, 2024

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@allgandalf
Copy link
Contributor

ig it's a regression from #35837, it changes the RNTextInput to MarkdownTextInput

@tomekzaw
Copy link
Contributor

tomekzaw commented Feb 8, 2024

ig it's a regression from #35837, it changes the RNTextInput to MarkdownTextInput

There's already an existing PR from @robertKozik for same thing but for Android & iOS, we could extend that:

@thienlnam thienlnam assigned thienlnam and unassigned hayata-suenaga Feb 8, 2024
@thienlnam
Copy link
Contributor

Taking this over since it deals with live markdown

@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 8, 2024
@thienlnam
Copy link
Contributor

thienlnam commented Feb 8, 2024

Doesn't look like it needs to be a blocker, but let's get this resolved soon! Will assign @robertKozik since it looks like we can wrap that into the existing PR

EDIT: just kidding, looks like you will have to comment on the issue for me to do that

@robertKozik
Copy link
Contributor

Now you should be able to assign 😄 . I'm going to work on extending the animated input fix now

@robertKozik
Copy link
Contributor

Looks like reintroducing animated component don't solve it. It's for sure problem with/lack of autofocus prop. CC. @Skalakid

@melvin-bot melvin-bot bot added the Overdue label Feb 12, 2024
@robertKozik
Copy link
Contributor

This PR contaions fix to the RCA of this issue: Expensify/react-native-live-markdown#175 .

Copy link

melvin-bot bot commented Feb 12, 2024

@thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot removed the Overdue label Feb 12, 2024
@thienlnam thienlnam added Weekly KSv2 and removed Daily KSv2 labels Feb 12, 2024
@thienlnam thienlnam changed the title Web - Composer - Composer is highlighted but there is no Insertion Pointer ( | ) in composer [HOLD https://github.com/Expensify/react-native-live-markdown/pull/175]Web - Composer - Composer is highlighted but there is no Insertion Pointer ( | ) in composer Feb 12, 2024
@robertKozik
Copy link
Contributor

Tested locally on release 0.1.9. Issue is no longer reproductible - Expensify/react-native-live-markdown#175 seems to solve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants