[HOLD for payment 2024-02-20] [HOLD for payment 2024-02-19] Request money - App reopens request details page after saving description

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: Y
Reproducible in staging?: N
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #35137

Action Performed:

1. Launch New Expensify app
2. Go to FAB > Request money
3. Create a manual request from any person
4. Navigate to request details view
5. Tap Description
6. Enter or edit the description and save it
7. Return to previous page using device back navigation

Expected Result:

In Step 6, the request details page will not reopen
In Step 7, app returns to IOU report

Actual Result:

In Step 6, the request details page reopens
In Step 7, app returns to the same request details page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6372489_1707422129564.Screen_Recording_20240209_032141_New_Expensify.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #vip-split-p2p-chat-groups

[marcaaron]

@deetergp @s77rt any chance you can look into this one. It sounds possibly related to the PR linked here.

[s77rt]

I confirm it's caused by that PR. This may not be a deploy blocker as the bug is already on production effecting other pages e.g. the receipt page.

Screen.Recording.2024-02-09.at.2.55.52.AM.mov

App/src/libs/Navigation/Navigation.ts

Lines 214 to 217 in 49886be

	if (shouldEnforceFallback || (isFirstRouteInNavigator && fallbackRoute)) {
	navigate(fallbackRoute, CONST.NAVIGATION.TYPE.UP);
	return;
	}

[s77rt]

cc @DylanDylann

[arosiclair]

Reproduced on iOS staging v1.4.39-0.

RPReplay_Final1707489042.MP4

[arosiclair]

No reproduction on iOS prod v1.4.38-6

BA3C69F4-EC90-4B2C-8ECD-62350643B897.MP4

[arosiclair]

Confirmed reverting #35137 fixes the issue. Posting a revert PR...

[Beamanator]

FYI the video in the OP doesn't really match the steps taken 😳

[Beamanator]

Fixed by #36287 & #36329

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Remove backTo for money request view #36287
• [CP Staging] Add nav backup back so we can CP to staging #36329

If no regressions arise, payment will be issued on 2024-02-19. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Remove backTo for money request view #36287
• [CP Staging] Add nav backup back so we can CP to staging #36329

If no regressions arise, payment will be issued on 2024-02-20. 🎊

[arosiclair]

I think this is all set