[HOLD for payment 2024-02-26] [HIGH] Move the policy tax enabled property to tax key

[mountiny]

Problem

Part of #36171

The policy. isTaxTrackingEnabled property does not exist in this shape in our policy data in database. Its saved as policy.tax.trackingEnabled : boolean. Given we are updating how the policy changes are being saved and propagated to the clients, its cleaner to keep this structure same in Onyx as well. Having different code and different data schema throughout the stack results in less straightforward, more confusing, and more bug prone code

Solution

Update the Policy schema and usage of the policy.isHarvestingEnabled property to expect this data in policy.tax.trackingEnabled : boolean format. Update the backend API to also return the data in this shape.

Steps:

1. Update the App to accept both formats. If policy.tax.trackingEnabled is not available, fallback to policy. isTaxTrackingEnabled in the mean time
2. Update Web to send the data as policy.tax.trackingEnabled
3. Update Auth to do the same
4. Remove the fallback for policy.isTaxTrackingEnabled from the App

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c25bc5a392761ffc
• Upwork Job ID: 1755684468719345664
• Last Price Increase: 2024-02-08

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c25bc5a392761ffc

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @ishpaul777 (Internal)

[melvin-bot]

@mountiny, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mountiny]

I am unfortunately ill, doing bare minimum now to unblock peeps. Will look if I can squeeze this one in too

[ishpaul777]

Wishing you a speedy recovery! 🌟

[mountiny]

created draft for the app Pr to add the new property

[mountiny]

Started with the App PR

[mountiny]

Web PR is up too

[mountiny]

No need for Auth changes its already there

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add the policy tax trackingEnabled #36521

If no regressions arise, payment will be issued on 2024-02-26. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @twisterdotcom you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• C+: @ishpaul777 paid $500 via Upwork here

BugZero Checklist (@twisterdotcom)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1755684468719345664/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[twisterdotcom]

https://expensify.slack.com/archives/C01SKUP7QR0/p1709049183234189

[ishpaul777]

not able to access the above thread is it for me @twisterdotcom ?

[twisterdotcom]

Ah sorry @ishpaul777 no. I was querying in Slack what the price was here, looks like we're going with $500, so I'll send a contract over in a mo.

[twisterdotcom]

Sent and updated the Payment Summary.

[ishpaul777]

Accepted! Thanks @twisterdotcom

[twisterdotcom]

Paid!