[HOLD https://github.com/Expensify/react-native-live-markdown/pull/175][$500] Highlight applied on editing and main composer

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.39-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Send a message
2. Apply offline mode
3. Hover over the sent message > click on 'Edit' icon

Expected Result:

Highlight should only be applied on editing composer

Actual Result:

Highlight is applied on editing and main composer

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6372779_1707437285389.Screen_Recording_2024-02-09_at_3.07.10_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014ad3d9a06c61cce3
• Upwork Job ID: 1755777260592553984
• Last Price Increase: 2024-02-09

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014ad3d9a06c61cce3

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Auto-assign attempt failed, all eligible assignees are OOO.

[rintoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The composer fails to focus during the mounting process.

What is the root cause of that problem?

The root cause is to do with the recent changes in MarkdownTextInput (inside Composer).

Despite the state of isFocused in ComposerWithSuggestions is true on mount, the MarkdownText component does not get focused, resulting in an out-of-sync state for the isFocused property.

This gives the impression that both inputs are focused in edit mode, even though the main composer itself is not in focus.

What changes do you think we should make in order to solve the problem?

Add below effect to ComposerWithSuggestions component will fix the issue.

https://github.com/Expensify/App/blob/main/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.js#L542

    // run once on load
    useEffect(() => {
      if (!isFocused) {return}
      focus(true)
      // eslint-disable-next-line react-hooks/exhaustive-deps
    }, [])

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

📣 @rintoj! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[rintoj]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01eaa7c76af4ae1bf1

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[thienlnam]

Related to #35837, we're reverting the PR

[thienlnam]

We've reverted the offending PR #35837, so this is no longer a blocker

[robertKozik]

Per @rintoj comment I think that this PR inside react-native-live-markdown library should fix this issue: Expensify/react-native-live-markdown#175 .

[cubuspl42]

Let's hold on Expensify/react-native-live-markdown#175 in such case. We'll repeat the repro steps to double confirm our issue is fixed.

[robertKozik]

Tested locally on release 0.1.9. Issue is no longer reproductible - Expensify/react-native-live-markdown#175 seems to solve this