[Awaiting Payment 4th March] [$500] Group chat - Group chat stacked avatars are different in Search list and LHN

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.39.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Create a group chat.
3. Open the search list.

Expected Result:

Group chat stacked avatars are the same in Search list and LHN.

Actual Result:

Group chat stacked avatars are different in Search list and LHN.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019ab5a919ca4de3e7
• Upwork Job ID: 1755954534505050112
• Last Price Increase: 2024-02-09
• Automatic offers:
• mollfpr | Reviewer | 0
• ZhenjaHorbach | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019ab5a919ca4de3e7

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kbecciv]

We think that this bug might be related to #vip-vsb
CC @quinthar

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Group chat - Group chat stacked avatars are different in Search list and LHN

What is the root cause of that problem?

The main problem with this issue is that we use different components for Header View, Search screen and for LHN

LHN

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Lines 173 to 192 in 433eeda

	(optionItem.shouldShowSubscript ? (
	<SubscriptAvatar
	backgroundColor={hovered && !isFocused ? hoveredBackgroundColor : subscriptAvatarBorderColor}
	mainAvatar={optionItem.icons?.[0]}
	secondaryAvatar={optionItem.icons?.[1]}
	size={viewMode === CONST.OPTION_MODE.COMPACT ? CONST.AVATAR_SIZE.SMALL : CONST.AVATAR_SIZE.DEFAULT}
	/>
	) : (
	<MultipleAvatars
	icons={optionItem.icons ?? []}
	isFocusMode={viewMode === CONST.OPTION_MODE.COMPACT}
	size={viewMode === CONST.OPTION_MODE.COMPACT ? CONST.AVATAR_SIZE.SMALL : CONST.AVATAR_SIZE.DEFAULT}
	secondAvatarStyle={[
	StyleUtils.getBackgroundAndBorderStyle(theme.sidebar),
	isFocused ? StyleUtils.getBackgroundAndBorderStyle(focusedBackgroundColor) : undefined,
	hovered && !isFocused ? StyleUtils.getBackgroundAndBorderStyle(hoveredBackgroundColor) : undefined,
	]}
	shouldShowTooltip={OptionsListUtils.shouldOptionShowTooltip(optionItem)}
	/>
	))}

Search screen Only SubscriptAvatar

App/src/components/SelectionList/UserListItem.tsx

Lines 13 to 19 in 207385a

	{!!item.icons && (
	<SubscriptAvatar
	mainAvatar={item.icons[0]}
	secondaryAvatar={item.icons[1]}
	showTooltip={showTooltip}
	/>
	)}

Header View

App/src/pages/home/HeaderView.js

Lines 238 to 249 in 874448c

	{shouldShowSubscript ? (
	<SubscriptAvatar
	mainAvatar={icons[0]}
	secondaryAvatar={icons[1]}
	size={defaultSubscriptSize}
	/>
	) : (
	<MultipleAvatars
	icons={icons}
	shouldShowTooltip={!isChatRoom || isChatThread}
	/>
	)}

What changes do you think we should make in order to solve the problem?

To fix this issue we can make uniformity between these screens
And add a new parameter shouldUseOnySubscriptAvatar for BaseListItemand set false(For items on Serch screen) If we want to use MultipleAvatars or SubscriptAvatar depending on shouldShowSubscript (Optional)

And then using shouldShowSubscript value from item which we get from createOption

App/src/libs/OptionsListUtils.ts

Line 651 in 1e47b6f

result.shouldShowSubscript = ReportUtils.shouldReportShowSubscript(report);

We will show MultipleAvatars or SubscriptAvatar same as on other screens

App/src/components/SelectionList/UserListItem.tsx

Lines 13 to 19 in 207385a

	{!!item.icons && (
	<SubscriptAvatar
	mainAvatar={item.icons[0]}
	secondaryAvatar={item.icons[1]}
	showTooltip={showTooltip}
	/>
	)}

What alternative solutions did you explore? (Optional)

NA

[trjExpensify]

Yeah, I agree this is a bug. That said, @marcaaron @JmillsExpensify - how far off are we on the new group chat icons?

[mollfpr]

To fix this issue we can make uniformity between these screens

@ZhenjaHorbach What kind of uniformity do you plan? Are these make a new component that control SubscriptAvatar and MultipleAvatars?

[ZhenjaHorbach]

To fix this issue we can make uniformity between these screens

@ZhenjaHorbach What kind of uniformity do you plan? Are these make a new component that control SubscriptAvatar and MultipleAvatars?

No, I most likely mean add a condition and use one of these components depending on the condition like on LHN or Header View

I think this is the most logical since we are using UserListItem in several places, we may want to save the display in other places and use another component in case of search page

[mollfpr]

We only have 1 place that not showing the SubscriptAvatar and MultipleAvatars together, so I'm okay with updating just for the search page.

@trjExpensify Do we need to get the answer first or I can just review the proposal?

[trjExpensify]

You can review the proposal!

[mollfpr]

The proposal from @ZhenjaHorbach looks good to me!

🎀 👀 🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @MariaHCD, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @mollfpr 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ZhenjaHorbach]

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

PR will be ready today or tomorrow

[marcaaron]

Yeah, I agree this is a bug. That said, @marcaaron @JmillsExpensify - how far off are we on the new group chat icons?

We'll add the default avatars in the first front end PR (which is not in progress yet). That'll come before the ability to add a custom avatar so it's one of the first changes we'll make.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mollfpr]

@trjExpensify This issue missing the label Awaiting Payment and the payment date. Could you update it? Also, the blocker issue seems not from the PR, context: #37109 (comment)

[trjExpensify]

Agreed. Updated!

[trjExpensify]

Payment summary as follows:

@ZhenjaHorbach - $500 for the fix
@mollfpr - $500 for the C+ review

Paid @ZhenjaHorbach.
@mollfpr please confirm when you've requested and we can close this out.

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR was found.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

I think the regression step should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Open app
2. Create a group chat.
3. Open the search list.
4. Verify that avatars on the Search list item look the same as in LHN and Header chat
5. 👍 or 👎

[mollfpr]

@trjExpensify Requested on the NewDot!

[trjExpensify]

Thanks, closing it out!

P.S I don't think we need a standalone regression test for this, as search is tested where this visual bug was found. We're also updating the group avatar style soon.

[JmillsExpensify]

$500 approved for @mollfpr based on this summary.