-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wokspace - WS background is now white and shows sharp corners #36246
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @marcochavezf ( |
offending PR #35564 Color changed for status bar which was referenced for animation background App/src/styles/theme/themes/light.ts Line 112 in 7defd02
App/src/styles/theme/themes/dark.ts Line 112 in 7defd02
|
PR #35672 addresses this issue. |
Cool I will add it to the |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
I think we would not CP that PR @kosmydel so either we separate the fix so it can be CPed or we remove the deploy blocker label from here @marcochavezf |
Sounds good, given that we're not going to remove the CP I'm going to remove the deploy blocker label |
This issue has not been updated in over 15 days. @marcochavezf eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
PR was deployed a month ago but the issue was not closed automatically. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v1.4.39-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Pre Cond: User has no WS created
Expected Result:
User expects to see a purple background on the WS modal as in PROD
Actual Result:
There is just a white on white background, this is the only banner without a colored background. IF this is the case now, the corners of the banner should now be rounded
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: