Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer - Email is not turned to a clickable link, and GitHub link is not parsed to number #36253

Closed
2 of 6 tasks
kbecciv opened this issue Feb 9, 2024 · 5 comments
Closed
2 of 6 tasks
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Feb 9, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.39-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause _ internal
Slack conversation:

Issue found when executing PR #35837

Action Performed:

Part 1 (Email):

  1. Open a chat
  2. Enter email address in composer ([email protected])
  3. Hover over the email & try to click the link

Part 2 (GitHub):

  1. Open a chat
  2. Enter a GitHub link in the composer (Live Markdown Preview #34292)

Expected Result:

Actual Result:

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6373589_1707484990756.Github.mp4
Bug6373589_1707484990742.Email.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Feb 9, 2024
Copy link
Contributor

github-actions bot commented Feb 9, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 9, 2024

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Feb 9, 2024

We think that this bug might be related to #vip-vsb
CC @quinthar

@Skalakid
Copy link
Contributor

Skalakid commented Feb 9, 2024

Hi, thanks for reporting a bug. Links inside live markdown text input shouldn't be clickable. Also links from GitHub shouldn't be shortened into numbers. We pasted wrong test cases into PR description, I will correct them

cc @tomekzaw

@dangrous
Copy link
Contributor

dangrous commented Feb 9, 2024

@Skalakid does that mean we can close this issue - i.e. not a bug?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants