[$500] Domain name is not dropped when sending text with user mention from same domain

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.40-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1.Go to staging.new.expensify.com
2. Go to any chat.
3. Send a message with mention of another user from the same private domain.

Expected Result:

The domain name is dropped because the user mention is from same domain.

Actual Result:

It shows domain name at the end of the mention in the message.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6376788_1707753873011.20240212_225341__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0190f9efc7bd55b768
• Upwork Job ID: 1757079921886003200
• Last Price Increase: 2024-02-12

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0190f9efc7bd55b768

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[isabelastisser]

@tylerkaraszewski @allroundexperts, what are the next steps here?

[allroundexperts]

Not sure if this is a deploy blocker. It seems to me that backend changes caused this issue. This should be fixed once #35532 gets resolved.

[Beamanator]

Great find @allroundexperts , I'll bring this to slack (here) but 99% sure this should not be a blocker

[NikkiWines]

#35532 is a separate issue for handling specifically the search and mention auto-fill functionality. If the domain name is not dropped from the mention itself (after sending) then there's been a regression since that functionality was added in this PR - associated issue here

[mkhutornyi]

This is regression from #35462 (bad merge)
#34013 was fully reverted while fixing conflict.
cc: @ruben-rebelo @mollfpr

[isabelastisser]

@tylerkaraszewski @allroundexperts, was this reverted, and can it be closed?

[NikkiWines]

No, mentions are still not shortened. I've asked if we can re-introduce the original logic from this PR as part of handling this issue since it's also tied to shortened mentions.

If the contributor working on that issue agrees, then we can close this issue out in favor of that one. If not, then we can handle re-implementing shortened mentions here

[melvin-bot]

@tylerkaraszewski, @allroundexperts, @isabelastisser Whoops! This issue is 2 days overdue. Let's get this updated quick!

[isabelastisser]

@allroundexperts, please follow up on Nikki's comment above. Thanks!

[allroundexperts]

Hi @isabelastisser!
@tienifr should be able to handle this case in his PR. @tienifr please confirm and then we can close this one.

[tienifr]

I think we should create the separate PR to fix this issue. BTW, it's the regression from #35462. Should we let @ruben-rebelo create the PR? It's very similar to #34013

[ruben-rebelo]

I'll take a look at this ASAP.
Sorry for the late reply

[isabelastisser]

Thanks @ruben-rebelo. Please provide an update when you have a chance.

[ruben-rebelo]

@isabelastisser I've created PR with the fix, I've just requested an Internal Review by Callstack before I open it for review.

[isabelastisser]

Great, thanks @ruben-rebelo!

[puneetlath]

It looks like the shortened mentions don't get rendered via the live markdown preview. Is that a bug from this PR or something we just haven't implemented yet?

[allroundexperts]

It looks like the shortened mentions don't get rendered via the live markdown preview. Is that a bug from this PR or something we just haven't implemented yet?

I don't think we ever implemented this @puneetlath

[NikkiWines]

This should've gone live as of the changes implemented in #36697 actually nvm - looking at the testing from that PR it doesn't seem like any of the mentions (shortened or not) were rendered via the live markdown preview

[puneetlath]

Ah ok, I created an issue for it here: #38025

[melvin-bot]

This issue has not been updated in over 15 days. @tylerkaraszewski, @allroundexperts, @isabelastisser eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@tylerkaraszewski, @allroundexperts, @isabelastisser, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.