[HOLD for payment 2024-02-20] [$250] Text with single backtick code block is not rendered correctly

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.40-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat.
3. Send a text with single backtick code block.

Expected Result:

The text with single backtick code block is rendered correctly.

Actual Result:

The text with single backtick code block appears with two boxes outside the text.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6376777_1707753717830.20240212_235003.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c1b63e23f853fcb5
• Upwork Job ID: 1757081161711943680
• Last Price Increase: 2024-02-13
• Automatic offers:
• ikevin127 | Contributor | 0

Issue Owner

Current Issue Owner: @Santhosh-Sellavel

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c1b63e23f853fcb5

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[ikevin127]

Proposal

Please re-state the problem that we are trying to solve in this issue

The text with single backtick code block appears with two boxes outside the text.

What is the root cause of that problem?

Looks to have been caused by the TS migration from this PR #35462, specifically the following diff:

-            defaultRendererProps={defaultRendererProps}
+            defaultRendererProps={{...defaultRendererProps, style: style as TextStyle}}

App/src/components/HTMLEngineProvider/HTMLRenderers/CodeRenderer.tsx

Line 44 in 39ac35a

defaultRendererProps={{...defaultRendererProps, style: style as TextStyle}}

The problem is that after migration we pass the entire style prop of the component instead of just passing the textStyle coming from const {boxModelStyle, otherStyle: textStyle} = splitBoxModelStyle(style) as we should considering that we type it as TextStyle.

What changes do you think we should make in order to solve the problem?

Only pass the textStyle to {...defaultRendererProps, style: style as TextStyle} instead of the entire styles object, like so:

    defaultRendererProps={{...defaultRendererProps, style: textStyle as TextStyle}}

Screenshots

MacOS: Chrome / Safari

Before	After

[ShivCrew]

PROPOSAL

Please re-state the problem that we are trying to solve in this issue

The text with single backtick code block appears with two boxes outside the text. This is happening on all of the below platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

What is the root cause of that problem?
This is happening because 'backtick' is an essential part of most coding languages. Either when a backtick is typed with a text and passed to the backend code, or when the text with a backtick is printed on the screen, at any one or both of these instances, backtick is getting mixed with the code resulting in unexpected results. It's difficult to come up with a definite reason without debugging on all of the platforms.

What changes do you think we should make in order to solve the problem?
At the time, the text with backtick is passed on to the backend script, the backtick may be replaced by any other key. Similarly, when it is printed, this other key may be replaced by a backtick again.

[melvin-bot]

📣 @ShivCrew! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[ShivCrew]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~018df9103ffcdb09b7?viewMode=1

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[aldo-expensify]

Conversation about compensation: https://expensify.slack.com/archives/C01GTK53T8Q/p1707781846347169

[aldo-expensify]

@kadiealexander I would like to suggest a $250 (half of $500) compensation for @ikevin127 since he helped by providing the correct RCA and pointing out the offending PR.

I'll remove @Santhosh-Sellavel since we didn't require a C+ review.

[melvin-bot]

Upwork job price has been updated to $250

[melvin-bot]

📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Beamanator]

@kavimuru @m-natarajan can someone please test #36360 on staging and confirm if this is resolved?

[ikevin127]

@Beamanator Tested just now on latest staging (v1.4.40-2).

MacOS: Chrome

Screen.Recording.2024-02-13.at.13.29.29.mov

[Beamanator]

Yes agreed, it looks like it's working well on staging macos & iOS!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert typescript migration change #36360

If no regressions arise, payment will be issued on 2024-02-20. 🎊

For reference, here are some details about the assignees on this issue:

• @ikevin127 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aldo-expensify] The PR that introduced the bug has been identified. Link to the PR:
• [@aldo-expensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aldo-expensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ikevin127] Determine if we should create a regression test for this bug.
• [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ikevin127]

• [@ikevin127] Determine if we should create a regression test for this bug.
• [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No need for regression tests here as this was caused by TS migration #35462 which was meant to only convert JS to TS, not change existing logic. More context here.

[kadiealexander]

@ikevin127 is paid!