HIGH: [Public] [$500] Members disappear after invitation in public rooms

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.40.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Create a workspace
2. Create a public room
3. Invite a new member (without an Expensify account)
4. Observe the member appearing momentarily and then disappearing
5. Refresh the page and observe the newly invited member on the member list

Expected Result:

The invited member shouldn't flash and then disappear

Actual Result:

The members disappear

Workaround:

Unknowns

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

2024-02-22_16-08-32.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016a8e93511c34c648
• Upwork Job ID: 1757156885762093056
• Last Price Increase: 2024-02-26

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016a8e93511c34c648

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kbecciv]

We think that this bug might be related #wave8-collect-admins
CC @zanyrenney

[bfitzexpensify]

I think this likely fits better with #vip-vsb. I want to test this a little more tomorrow myself to determine priority.

[bfitzexpensify]

OK, doing a little further digging here:

• tried this both with a new gmail account ([email protected]) and my [email protected] testing account
• after refreshing the page, the invited members appear on the list, but no emails are received (tested with both @gmail.com and @expensifail.com accounts)
• however, I am part of those channels. This works both for invites originating from @expensifail.com - this is me signed in to [email protected] and I'm part of the #test room that was created via [email protected]:

And via @gmail.com - this is me signed in to [email protected], seeing a room I was invited to from [email protected]:

So, it seems like the problems here aren't specific to gmail, and are the following:

1. Invited members only appear on the members list after refreshing the page post-invite
2. We're not sending invite emails at all, regardless of the source (private or public email domain)

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[bfitzexpensify]

Raised in the #vip-vsb room here

[bfitzexpensify]

Added this to the #vip-vsb project, and split out the two issues - keeping the members-disappearing sub-issue here, and taking the emails not being delivered to #37067

[brunovjk]

I believe there is an irregularity with the api InviteToRoom response. When we invite to a non-public room, the response is complete:

'InviteToRoom' response to a non-public room

However, when we invite to a public room, the backend response seems incomplete to me:

'InviteToRoom' response to a public room

Is this expected? Offline works normally.

[bfitzexpensify]

@marcochavezf do you have some context on this? Looks like you were working on some InviteToRoom items in #30919

[wildan-m]

Hi, I have a proposal posted here. It's about personalDetails filtering. Currently, we do not display members with no personal details. If we want to show them, we should consider my alternative proposal to remove the personalDetails null check in RoomMembersPage.

[melvin-bot]

@fedirjh @bfitzexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[bfitzexpensify]

Still awaiting an internal volunteer. Shared in the #vip-vsb update so it's visible for someone looking for something.

[bfitzexpensify]

Same update, still waiting on a volunteer.

[melvin-bot]

@fedirjh, @bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[bfitzexpensify]

Same update

[bfitzexpensify]

Still awaiting an internal volunteer

[melvin-bot]

@fedirjh, @bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[bfitzexpensify]

Same status - awaiting internal engineering. This issue is still being highlighted in the #vip-vsb Spring 24 items that need to be completed, so it's not going unnoticed.

[melvin-bot]

@fedirjh, @bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@fedirjh, @bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[bfitzexpensify]

Same status - awaiting internal engineering.

[bfitzexpensify]

No change here.

[bfitzexpensify]

Closing in favour of #40459, which Youssef is assigned to. I added the details of reproduction and the likely cause from this issue into that issue.