[$500] When editing tag field, the last one chosen does not appear on the recent list

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.40-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Pre-requisite: the user must have created a collect workspace with tags and have invited a member as employee.

1. As the employee, go to WS chat.
2. Create a manual money request, select tag A.
3. Go to the details page of newly created expense.
4. Tap on the tag field, choose tag B.
5. Go to WS chat again and initiate a new manual money request.
6. Tap on the tag field.
7. Verify tag B is not on the recent list.

Expected Result:

Tag B should appear on the recent list of tags.

Actual Result:

Tab B does not appear on the recent list.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6377448_1707783017476.Vyky5934_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018093514c21b6b93e
• Upwork Job ID: 1757214198782668800
• Last Price Increase: 2024-02-13

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018093514c21b6b93e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[m-natarajan]

We (Applause)think this bug might be related to #wave6-collect-submitters
cc @greg-schroeder

[barros001]

This looks like a BE issue.

App/src/libs/actions/IOU.ts

Lines 1186 to 1196 in 023d62c

	// Update recently used categories if the tag is changed
	if ('tag' in transactionChanges) {
	const optimisticPolicyRecentlyUsedTags = Policy.buildOptimisticPolicyRecentlyUsedTags(iouReport?.policyID, transactionChanges.tag);
	if (!isEmptyObject(optimisticPolicyRecentlyUsedTags)) {
	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY_RECENTLY_USED_TAGS}${iouReport?.policyID}`,
	value: optimisticPolicyRecentlyUsedTags,
	});
	}
	}

Here Onyx is correctly updated, optimistically, but when the response is received back from the BE, the recently used tags key is overwritten:

       {
            "onyxMethod": "set",
            "key": "policyRecentlyUsedTags_D10DE92FDB9B1CA9",
            "value": {
                "Tag": [
                    "Tag1"
                ]
            }
        }

This is when OpenReport is called right after updating the tag with Tag2. BE resets it back to only Tag1 (tag originally used to create the IOU).

[rushatgabhane]

🎀 👀 🎀 possible internal issue

[melvin-bot]

Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[arosiclair]

Reaching out to the wave6 team for this here

[arosiclair]

Looks like a dupe of #35506. Closing this out