Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Push notification no longer displays conversation title #36412

Closed
Julesssss opened this issue Feb 13, 2024 · 5 comments
Closed

[Android] Push notification no longer displays conversation title #36412

Julesssss opened this issue Feb 13, 2024 · 5 comments
Assignees
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@Julesssss
Copy link
Contributor

Julesssss commented Feb 13, 2024

Problem

As of this week, we no longer display the push notification conversation titles. This is a regression likely coming from this notification cache PR.

Screenshot 2024-02-13 at 13 34 45

Solution

This is blocking my critical VIP-VSB issue so I'm going to handle it.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0128383058c64efb20
  • Upwork Job ID: 1757398305408024576
  • Last Price Increase: 2024-02-13
@Julesssss Julesssss added Engineering Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Feb 13, 2024
@Julesssss Julesssss self-assigned this Feb 13, 2024
Copy link

melvin-bot bot commented Feb 13, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0128383058c64efb20

Copy link

melvin-bot bot commented Feb 13, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @shubham1206agra (Internal)

@Julesssss
Copy link
Contributor Author

Julesssss commented Feb 13, 2024

Today I generated native builds which took a while to configure and compile. After debugging I have located a couple of potential causes, but will need more time tomorrow to confirm them.

@Julesssss
Copy link
Contributor Author

Notifications working?

  • AdHoc build: ✅
  • Local prod build: ❌

Push Data:

{
  "reportID": 74984251,
  "reportActionID": "1418134007167197202",
  "shouldScrollToLastUnread": true,
  "title": "Hari Seldon",
  "type": "reportComment",
  "onyxData": [
    {
      "onyxMethod": "merge",
      "value": {
        "lastVisibleActionCreated": "2024-02-13 16:42:02.560",
        "maxSequenceNumber": 506,
        "lastMessageText": "asd",
        "reportID": "74984251",
        "lastActorAccountID": 8879888
      },
      "key": "report_74984251"
    },
    {
      "shouldNotify": true,
      "onyxMethod": "merge",
      "value": {
        "1418134007167197202": {
          "sequenceNumber": 506,
          "created": "2024-02-13 16:42:02.560",
          "reportActionTimestamp": 1707842522560,
          "automatic": false,
          "shouldShow": true,
          "avatar": "https://d1wpcgnaa73g0y.cloudfront.net/04bb9a8b30a0fe1783343ca005d096c578dff6c6_128.jpeg",
          "message": [
            {
              "isDeletedParentAction": false,
              "html": "asd",
              "isEdited": false,
              "reactions": [],
              "text": "asd",
              "whisperedTo": [],
              "type": "COMMENT"
            }
          ],
          "previousReportActionID": "3051314194010923703",
          "actorAccountID": 8879888,
          "whisperedToAccountIDs": [],
          "isAttachment": false,
          "reportActionID": "1418134007167197202",
          "person": [
            {
              "style": "strong",
              "text": "Hari Seldon",
              "type": "TEXT"
            }
          ],
          "lastModified": "2024-02-13 16:42:02.560",
          "originalMessage": {
            "html": "asd",
            "lastModified": "2024-02-13 16:42:02.560"
          },
          "timestamp": 1707842522,
          "actionName": "ADDCOMMENT"
        }
      },
      "key": "reportActions_74984251"
    }
  ]
}

@Julesssss
Copy link
Contributor Author

Unable to reproduce now for rooms and threads, using the latest build. Closing

Screenshot 2024-02-13 at 16 47 56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

2 participants