[$500] IOU - In distance request confirmation page, location access permission box is shown.

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.41
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4314136
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre:condition: device location is off

1. Launch app
2. Tap on workspace chat
3. Tap plus icon --- request money---distance
4. Tap no, thanks and deny device location permission
5. Tap start
6. Tap use location
7. Tap no, thanks and deny device location permission
8. Tap cross button and close the device location denied message
9. Select a location from dropdown list
10. Tap finish
11. Perfom step 6-- step9
12. Tap add stop
13. Perfom step 6-- step9
14. Tap next

Expected Result:

In distance request confirmation page, location access permission box must not be shown

Actual Result:

In distance request confirmation page, location access permission box is shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6379190_1707908248130.do.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01898dd3cbc3df8779
• Upwork Job ID: 1757774834158333952
• Last Price Increase: 2024-02-14
• Automatic offers:
• s77rt | Reviewer | 0
• bernhardoj | Contributor | 0
• esh-g | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01898dd3cbc3df8779

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

We think that this bug might be related to #wave5
CC @dylanexpensify

[esh-g]

Proposal

Please re-state the problem we are trying to solve

In distance request confirmation page, location access permission box is shown

What is the root cause of this problem?

The root cause is that we try to get the current position of the user for every render for MapView even if we don't need it in this useEffect here:

App/src/components/MapView/MapView.tsx

Line 46 in 2e3840f

getCurrentPosition(

What changes should be made to fix this?

We should only try to get the current location of the user if shouldPanMapToCurrentLocation is true

App/src/components/MapView/MapView.tsx

Line 68 in 2e3840f

const shouldPanMapToCurrentPosition = useCallback(() => !userInteractedWithMap && (!waypoints || waypoints.length === 0), [userInteractedWithMap, waypoints]);

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In distance confirmation page, a location permission dialog shows.

What is the root cause of that problem?

The map view component has a useFocusEffect that will be triggered every time the page is focused.

App/src/components/MapView/MapView.tsx

Lines 35 to 46 in 9b7e310

	useFocusEffect(
	useCallback(() => {
	if (isOffline) {
	return;
	}
	if (hasAskedForLocationPermission.current) {
	return;
	}
	hasAskedForLocationPermission.current = true;
	getCurrentPosition(

It will call getCurrentPosition which will request the location permission. The map view is also placed on the confirmation page, so when we visit the confirmation page, the permission dialog will be shown (no need to perform the long step).

What changes do you think we should make in order to solve the problem?

I think we don't need to get the current position anymore on the confirmation page, so we can introduce a new prop to ignore the getCurrentPosition call and set the current position from the initialState.

if (useInitialStatePosition) {
    setCurrentPosition({longitude: initialState.location[0], latitude: initialState.location[1]});
    return;
}

[s77rt]

@esh-g Thanks for the proposal. Your RCA is about right. The solution looks good to me.

🎀 👀 🎀 C+ reviewed
Link to proposal

[s77rt]

@bernhardoj Thanks for the proposal. Your RCA is about right. As for the solution, I don't think we need a new prop here

[melvin-bot]

Triggered auto assignment to @chiragsalian, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[chiragsalian]

Proposal sounds good to me, feel free to create the PR @bernhardoj.

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[esh-g]

@chiragsalian I think @s77rt recommended my proposal instead... could you please double check your decision?

[esh-g]

Gentle bump @chiragsalian @s77rt

[chiragsalian]

oh whoops, i'm so sorry. Reassigning to @esh-g.

[melvin-bot]

📣 @esh-g 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[chiragsalian]

Thanks for quickly bringing that to my attention. I've gone ahead and reassigned the issue to you @esh-g. Feel free to make a PR.

[esh-g]

PR is here: #36761
cc @s77rt

[kevinksullivan]

PR merged! Waiting on deploy.

[esh-g]

@chiragsalian @kevinksullivan I think the issue PR has already crossed the production timeline. Could you please list if anything is pending? Thanks!

[chiragsalian]

Oh true, its been live since feb 28th so this is past the 7 day regression period. I'm unsure why the GH title didn't change here. Might have been a bug.
I don't think anything is pending here.
@kevinksullivan can you handle the payment and close out this issue.

[melvin-bot]

This issue has not been updated in over 15 days. @chiragsalian, @s77rt, @kevinksullivan, @esh-g eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[s77rt]

This is due payment

[chiragsalian]

Friendly bump @kevinksullivan, to handle payment.

[melvin-bot]

@chiragsalian, @s77rt, @kevinksullivan, @esh-g, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[s77rt]

Only Melvin got paid. This is still due payment

[chiragsalian]

@kevinksullivan / @mallenexpensify, can one of you handle payment for @s77rt over here.

[mallenexpensify]

Contributor: @esh-g paid $500 via Upwork
Contributor+: @s77rt paid $500 via Upwork.

Sorry it took forever. If you ever see a Reviewing label on an issue when it's awaiting payment, please comment and ask for it to be removed