Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #34692] [VIP-VSB] [$500] Web - Task - Empty user shows up on share somewhere list #36492

Closed
1 of 6 tasks
kbecciv opened this issue Feb 14, 2024 · 36 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Help Wanted Apply this label when an issue is open to proposals by contributors Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Feb 14, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.41.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4311499
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Navigate to https://staging.new.expensify.com/a/14931991
  2. Click on Message with share code tests
  3. Click on FAB > Assign tasks > Give title > Click on share somewhere
  4. Observe the list of users

Expected Result:

Share code tests account should be shown with its avatar and its name

Actual Result:

Share code tests account shows up with an empty name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6379212_1707909253200.share_code_error.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b7f4ea28196d6fab
  • Upwork Job ID: 1757775322633478144
  • Last Price Increase: 2024-02-14
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 14, 2024
@melvin-bot melvin-bot bot changed the title Web - Task - Empty user shows up on share somewhere list [$500] Web - Task - Empty user shows up on share somewhere list Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01b7f4ea28196d6fab

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

Copy link

melvin-bot bot commented Feb 14, 2024

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@kbecciv
Copy link
Author

kbecciv commented Feb 14, 2024

We think that this bug might be related #vip-vsb
CC @quinthar

@strepanier03
Copy link
Contributor

Repro'd
image

@Tony-MK
Copy link
Contributor

Tony-MK commented Feb 17, 2024

@s77rt, I believe this issue is related to #35679.

@s77rt
Copy link
Contributor

s77rt commented Feb 17, 2024

🎀 👀 🎀 Internal. User initiated reports have empty visibleChatMemberAccountIDs. When you start a chat with a new user or a new group I expected visibleChatMemberAccountIDs to be same as participantAccountIDs.

Copy link

melvin-bot bot commented Feb 17, 2024

Triggered auto assignment to @bondydaa, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2024
@bondydaa
Copy link
Contributor

tested again since we've had a few new releases since it was created and am still able to reproduce
image

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 19, 2024
@bondydaa
Copy link
Contributor

@s77rt can you link to where the API call is made that isn't properly returning visibleChatMemberAccountIDs so I can try and track down exactly where or what might have changed?

@melvin-bot melvin-bot bot removed the Overdue label Feb 19, 2024
@bondydaa bondydaa added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels Feb 19, 2024
Copy link

melvin-bot bot commented Feb 19, 2024

Current assignee @s77rt is eligible for the Internal assigner, not assigning anyone new.

@bondydaa bondydaa removed their assignment Feb 19, 2024
@rlinoz rlinoz changed the title [VIP-VSB] [$500] Web - Task - Empty user shows up on share somewhere list [HOLD Expensify/Expensify#341000][VIP-VSB] [$500] Web - Task - Empty user shows up on share somewhere list Mar 5, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Mar 5, 2024

Let's hold on that

@rlinoz rlinoz added Weekly KSv2 and removed Daily KSv2 labels Mar 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 13, 2024
@strepanier03
Copy link
Contributor

Got it, thanks all.

@melvin-bot melvin-bot bot removed the Overdue label Mar 13, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 25, 2024
@strepanier03
Copy link
Contributor

Hold PR still open.

@melvin-bot melvin-bot bot removed the Overdue label Mar 27, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 5, 2024
@strepanier03
Copy link
Contributor

@s77rt - I noticed the PR this was deployed and closed for another GH that is currently on hold, https://github.com/Expensify/Expensify/issues/383292.

Can you take a quick peek and confirm that I should update the title for our GH to be on hold for 383292 now? I believe it is based on the fields that GH is going to be removing.

@melvin-bot melvin-bot bot removed the Overdue label Apr 16, 2024
@s77rt
Copy link
Contributor

s77rt commented Apr 17, 2024

@strepanier03 I don't have access to the Expensify repo. Maybe @rlinoz can take a look?

@rlinoz
Copy link
Contributor

rlinoz commented Apr 17, 2024

I think we should HOLD on #34692 which will update to the new format, sounds good?

@strepanier03
Copy link
Contributor

Sounds great @rlinoz thanks for weighing in and suggesting it. I'll update the title now.

@strepanier03 strepanier03 changed the title [HOLD Expensify/Expensify#341000][VIP-VSB] [$500] Web - Task - Empty user shows up on share somewhere list [HOLD #34692] [VIP-VSB] [$500] Web - Task - Empty user shows up on share somewhere list Apr 17, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 26, 2024
@s77rt
Copy link
Contributor

s77rt commented Apr 28, 2024

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Apr 28, 2024
@melvin-bot melvin-bot bot added the Overdue label May 6, 2024
@s77rt
Copy link
Contributor

s77rt commented May 6, 2024

Same ^

@melvin-bot melvin-bot bot removed the Overdue label May 6, 2024
@melvin-bot melvin-bot bot added the Overdue label May 14, 2024
@s77rt
Copy link
Contributor

s77rt commented May 17, 2024

Let's close this, issue no longer reproducible.

@melvin-bot melvin-bot bot removed the Overdue label May 17, 2024
@melvin-bot melvin-bot bot added the Overdue label May 27, 2024
@s77rt
Copy link
Contributor

s77rt commented May 27, 2024

@strepanier03 We can close this

@melvin-bot melvin-bot bot removed the Overdue label May 27, 2024
@rlinoz rlinoz closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Help Wanted Apply this label when an issue is open to proposals by contributors Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

6 participants