Expense - "Next step" message changes when requesting money offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.41-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

• Employee is in Collect workspace
• Schedule submit is enabled and set to Daily

1. Go to workspace chat
2. Create a manual request
3. Click on the preview to go to expense report
4. Note that the Next step message is "These expenses are scheduled to automatically submit later today!"
5. Go offline
6. Create another manual request
7. Go to expense report

Expected Result:

The "Next step" message remains the same, which is "These expenses are scheduled to automatically submit later today!"

Actual Result:

The "Next step" message changes to "Waiting for x to approve these expenses."

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6379360_1707916650292.20240214_184640.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #wave6
CC @greg-schroeder

[rlinoz]

Hmm, I believe this should be happening in prod as well.

Anyway, maybe @mountiny, @rezkiy37 or @allroundexperts can help.

I think it is related to this PR: #34450, specifically this line:

App/src/libs/actions/IOU.ts

Line 876 in 63733d8

const optimisticNextStep = NextStepUtils.buildNextStep(iouReport, needsToBeManuallySubmitted ? CONST.REPORT.STATUS_NUM.OPEN : CONST.REPORT.STATUS_NUM.SUBMITTED);

Because the next status is submitted we change the message to pending approval.

[Beamanator]

ooh if this is happening in prod, let's call this NAB! Can you confirm @rlinoz ? 🙏

[rezkiy37]

It is a regressing of this issue. I am going to take and fix this.

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

[rlinoz]

@rezkiy37 I think GH failed to link the issue, do you mind linking it again?

Also, do you happen to know if this is prod? If it is the PR I linked it is deployed, so this would not be a blocker.

[rezkiy37]

What's the linking do you mean? It already mentioned this issue - #28771.

[rlinoz]

Oh I thought the bold issue in your comment was supposed to be a link, sorry.

Great, so this seems to be deployed to production and we can the blocker label.

[mountiny]

This PR is already in production so not a blocker

[mountiny]

But please do continue with the fix just no need to CP @rezkiy37

[rezkiy37]

I can confirm that it is deployed. So, it is not a blocker.

Bug.mp4

[rezkiy37]

Looks like I've found a root cause of the bug. Testing and opening a PR tomorrow.

[thesahindia]

Precondition:

• Employee is in Collect workspace

Collect workspace is just a normal workspace right?

• Schedule submit is enabled and set to Daily

How can I do that?

Can you help with that @rlinoz @mountiny ?

[rezkiy37]

@thesahindia, let me clarify:

1. Collect workspace is just a normal workspace right?

No, it is one of type of paid workspaces. You need to use OD for creating paid workspaces.

2. How can I do that?

You need to use OD for managing paid workspaces.

Does it make sense now?

[melvin-bot]

This issue has not been updated in over 15 days. @rlinoz, @rezkiy37 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[rlinoz]

Hmmm this is in prod already, are we missing something?

[rezkiy37]

Yes, it is in prod - #36529 (comment).

[rlinoz]

Yep, closing then

[thesahindia]

@rlinoz, I didn't request the compensation for the C+ review at #36529. I am sending the money request on new dot but I need a payment summary for it to get approved. Please help me with that.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[rlinoz]

Sorry about that @thesahindia

@Christinadobrzyn , @thesahindia was the C+ reviewer for this issue, can you handle payment please?

[thesahindia]

@Christinadobrzyn, we just need the payment summary here. Thanks!

[Christinadobrzyn]

Gotcha! Payouts due:

• Contributor+: $500 @thesahindia (Paid in NewDot)

@thesahindia you are paid in NewDot, right? Do we need a regression test here?

[thesahindia]

@thesahindia you are paid in NewDot, right? Do we need a regression test here?

I don't think this needs a specific test case but if we want here are the steps-

1. Go to workspace chat
2. Create a manual request
3. Click on the preview to go to expense report
4. Note that the Next step message is "These expenses are scheduled to automatically submit later today!"
5. Go offline
6. Create another manual request
7. Go to expense report
8. Verify: the "Next step" message remains the same, which is "These expenses are scheduled to automatically submit later today!"

Feel free to close it. I will send the money request on NewDot.

[Christinadobrzyn]

Created a regression test for QA to review if we need to add this - https://github.com/Expensify/Expensify/issues/386621

Payment summary here - #36510 (comment)

going to close this out, feel free to reach out if I've missed anything!

[JmillsExpensify]

$500 approved for @thesahindia