Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Web - Settings - The language stays on Spanish #36516

Closed
6 tasks done
lanitochka17 opened this issue Feb 14, 2024 · 15 comments
Closed
6 tasks done

[$500] Web - Settings - The language stays on Spanish #36516

lanitochka17 opened this issue Feb 14, 2024 · 15 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Not a priority

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 14, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.41.1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #35509

Action Performed:

  1. Web/Chrome: Log in (The language should be English)
  2. mWeb/Safari: Change the language to Spanish before logging in
  3. mWeb/Safari: Log in with the same account
  4. mWeb/Safari: Change the language to English
  5. mWeb/Safari: Change the language to Spanish again

Expected Result:

It should be changing to Spanish on all devices if you switch to it on the login screen and proceed to log in with a secondary device

Actual Result:

The language only switches to Spanish if you switch to English and back to Spanish

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6379457_1707921712472.Web.mp4
Bug6379457_1707921712463.mWeb.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01074547adb1be45f1
  • Upwork Job ID: 1757904101628276736
  • Last Price Increase: 2024-02-14
@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01d9f8d3835b5d1a32

@melvin-bot melvin-bot bot changed the title Web - Settings - The language stays on Spanish [$500] Web - Settings - The language stays on Spanish Feb 14, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

Copy link

melvin-bot bot commented Feb 14, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@barros001
Copy link
Contributor

This looks like a BE issue. When the user lands on the login page it will set the preferredLocale to es. When user actually logs in, the backend will set the preferred locale in the BE to es but it will not push this change via pusher as it does when the locale is manually changed. This causes other sessions being out of sync. The fix in this case would be to make the backend broadcast (vis pusher) a change of locale when the preferredLocale is updated when the user logs in.

@twisterdotcom twisterdotcom added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01074547adb1be45f1

Copy link

melvin-bot bot commented Feb 14, 2024

Current assignee @eVoloshchak is eligible for the Internal assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Feb 28, 2024

@eVoloshchak @twisterdotcom this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Feb 28, 2024
@eVoloshchak
Copy link
Contributor

@twisterdotcom, i agree with @barros001's comment (#36516 (comment)), this does look like a back-end issue, which makes this issue Internal

@twisterdotcom
Copy link
Contributor

Yeah, we have the Internal label. We'll get around to this when we can. Going to make it Monthly again.

@twisterdotcom twisterdotcom added Monthly KSv2 and removed Daily KSv2 labels Feb 29, 2024
Copy link

melvin-bot bot commented Mar 6, 2024

@eVoloshchak @twisterdotcom this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@melvin-bot melvin-bot bot added Engineering Daily KSv2 and removed Monthly KSv2 labels Mar 6, 2024
@twisterdotcom twisterdotcom added Monthly KSv2 and removed Daily KSv2 labels Mar 6, 2024
Copy link

melvin-bot bot commented Mar 13, 2024

@eVoloshchak @twisterdotcom this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Monthly KSv2 labels Mar 13, 2024
@twisterdotcom
Copy link
Contributor

This is Monthly Melv.

@melvin-bot melvin-bot bot removed the Overdue label Mar 14, 2024
@twisterdotcom twisterdotcom added Monthly KSv2 and removed Daily KSv2 labels Mar 14, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 15, 2024
@twisterdotcom
Copy link
Contributor

Low priority issue

@melvin-bot melvin-bot bot removed the Overdue label Apr 15, 2024
@melvin-bot melvin-bot bot added the Overdue label May 16, 2024
@twisterdotcom
Copy link
Contributor

Still Monthly

@twisterdotcom
Copy link
Contributor

VSB stuff is very low on the agenda. Marking this as not a priority and closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Not a priority
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants