Fix/35945: Selected category is not highlighted #36596

dukenv0307 · 2024-02-15T15:54:08Z

Details

Selected category not highlighted if other category removed by WS Admin

Fixed Issues

$ #35945
PROPOSAL: #35945 (comment)

Tests

Log in to New Expensify as Employee from prerequisites
Navigate to workspace chat > start manual request
Enter an amount > Next > Category > Select any Category
Tap Category once more
As Workspace Admin in OD - remove any other Category
The removed category should disappear from Employee's categories list, and the focused category should remain highlighted

Verify that no errors appear in the JS console

Offline tests

QA Steps

Log in to New Expensify as Employee from prerequisites
Navigate to workspace chat > start manual request
Enter an amount > Next > Category > Select any Category
Tap Category once more
As Workspace Admin in OD - remove any other Category
The removed category should disappear from Employee's categories list, and the focused category should remain highlighted

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screencast.from.19-02-2024.15.13.44.webm

Android: mWeb Chrome

Screencast.from.16-02-2024.00.30.11.webm

iOS: Native

Screencast.from.16-02-2024.00.19.59.webm

iOS: mWeb Safari

Screencast.from.16-02-2024.00.31.01.webm

MacOS: Chrome / Safari

Screencast.from.15-02-2024.22.48.54.webm

MacOS: Desktop

Screencast.from.15-02-2024.23.43.57.webm

melvin-bot · 2024-02-15T16:45:43Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2024-02-17T01:34:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-17.at.6.44.45.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-02-17.at.6.43.42.AM.mov

iOS: Native

Screen.Recording.2024-02-17.at.6.42.46.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-02-17.at.6.41.48.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-17.at.6.38.46.AM.mov

MacOS: Desktop

Screen.Recording.2024-02-17.at.6.40.31.AM.mov

src/components/OptionsSelector/BaseOptionsSelector.js

allroundexperts

@dukenv0307 Android screen recording is missing.

dukenv0307 · 2024-02-19T08:15:25Z

@allroundexperts I fixed all your comments

allroundexperts

Looks good!

OSBotify · 2024-02-20T14:51:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-26T21:07:59Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-28T23:56:35Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Krishna2323 · 2024-03-06T14:16:54Z

@allroundexperts @dukenv0307, this has caused a regression, in the video below you can see when I search for tags it focuses on the last option instead of the first option.

error_focus.mp4

allroundexperts · 2024-03-06T14:25:25Z

@dukenv0307 Can you check / verify?

dukenv0307 · 2024-03-06T14:42:43Z

Thanks for your information @Krishna2323. I agree that the behavior in here is caused by this PR. I will raise a PR to fix it

dukenv0307 · 2024-03-07T01:02:09Z

@allroundexperts The issue here occurs with OptionSelector (TagPicker for example). But now the OptionSelector is deprecated and we use SelectionList (CategoryPicker for example). So in the future, this bug will not occur anymore. So should we still need to create a PR to fix it? WDYT? cc @luacmartins

luacmartins · 2024-03-07T15:24:13Z

Have we updated the view to use SelectionList already?

dukenv0307 · 2024-03-07T15:30:01Z

@luacmartins We have not updated the TagPicker to use SelectionList yet, but the OptionSelector is marked as deprecated

allroundexperts · 2024-03-07T15:32:16Z

Might be better to update tag picker to use selection list instead?

dukenv0307 · 2024-03-07T15:38:00Z

Here is the discussion in case you need it

luacmartins · 2024-03-07T22:13:29Z

Ah cool, so it seems like there's a plan to update the components using OptionList already, so I think we can do nothing here.

dukenv0307 added 3 commits February 15, 2024 22:49

fix selected category is not highlighted

c431f9e

fix logic issue

10df32a

fix remove hardcode

a16983b

dukenv0307 marked this pull request as ready for review February 15, 2024 16:45

dukenv0307 requested a review from a team as a code owner February 15, 2024 16:45

melvin-bot bot requested review from allroundexperts and removed request for a team February 15, 2024 16:45

dukenv0307 mentioned this pull request Feb 15, 2024

[HOLD for payment 2024-03-04] [$500] [MEDIUM] Categories: Selected category not highlighted if other category removed by WS Admin #35945

Closed

6 tasks

allroundexperts reviewed Feb 17, 2024

View reviewed changes

src/components/OptionsSelector/BaseOptionsSelector.js Outdated Show resolved Hide resolved

allroundexperts suggested changes Feb 17, 2024

View reviewed changes

fix import lib issue

54a92b6

allroundexperts approved these changes Feb 20, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins February 20, 2024 03:58

luacmartins approved these changes Feb 20, 2024

View reviewed changes

luacmartins merged commit a21cfbc into Expensify:main Feb 20, 2024
18 checks passed

github-actions bot mentioned this pull request Feb 26, 2024

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed

Krishna2323 mentioned this pull request Feb 29, 2024

[HOLD for payment 2024-07-10] [$500] Workspace switcher - Selection disappears after erasing character with workspace selected #36140

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/35945: Selected category is not highlighted #36596

Fix/35945: Selected category is not highlighted #36596

dukenv0307 commented Feb 15, 2024 •

edited

Loading

melvin-bot bot commented Feb 15, 2024

allroundexperts commented Feb 17, 2024 •

edited

Loading

allroundexperts left a comment

dukenv0307 commented Feb 19, 2024

allroundexperts left a comment

OSBotify commented Feb 20, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

Krishna2323 commented Mar 6, 2024

allroundexperts commented Mar 6, 2024

dukenv0307 commented Mar 6, 2024

dukenv0307 commented Mar 7, 2024

luacmartins commented Mar 7, 2024

dukenv0307 commented Mar 7, 2024

allroundexperts commented Mar 7, 2024

dukenv0307 commented Mar 7, 2024

luacmartins commented Mar 7, 2024

Fix/35945: Selected category is not highlighted #36596

Fix/35945: Selected category is not highlighted #36596

Conversation

dukenv0307 commented Feb 15, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 15, 2024

allroundexperts commented Feb 17, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts left a comment

Choose a reason for hiding this comment

dukenv0307 commented Feb 19, 2024

allroundexperts left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 20, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

Krishna2323 commented Mar 6, 2024

allroundexperts commented Mar 6, 2024

dukenv0307 commented Mar 6, 2024

dukenv0307 commented Mar 7, 2024

luacmartins commented Mar 7, 2024

dukenv0307 commented Mar 7, 2024

allroundexperts commented Mar 7, 2024

dukenv0307 commented Mar 7, 2024

luacmartins commented Mar 7, 2024

dukenv0307 commented Feb 15, 2024 •

edited

Loading

allroundexperts commented Feb 17, 2024 •

edited

Loading