Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile - Data is not loaded when go back online after page resetting with “Troubleshooting” #36601

Closed
3 of 6 tasks
kbecciv opened this issue Feb 15, 2024 · 17 comments
Closed
3 of 6 tasks
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Feb 15, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.42-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #35306

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Login
  3. Go offline
  4. Go to Profile -> About -> Troubleshoot
  5. Press "Reset and refresh"
  6. Confirm the modal
  7. Go to home screen and verify skeleton is displayed
  8. Go online
  9. Wait and verify the data is loaded

Expected Result:

Data is loaded when go back online

Actual Result:

Data is not loaded when go back online. Data is loaded after relogin.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6380789_1708009502838.feat_Troubleshooting_page___resetting_Onyx_state.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Feb 15, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 15, 2024

Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@rlinoz
Copy link
Contributor

rlinoz commented Feb 15, 2024

I can reliably reproduce, the screen was just added in this PR #35306, but since it is not a main feature I don't think we should block on it.

@TMisiukiewicz, would you be able to take a look at this?

@Beamanator
Copy link
Contributor

I don't think this is a deploy blocker either, since this is a Troubleshooting page that is pretty new, thoughts @rlinoz ?

@Beamanator
Copy link
Contributor

Oh it sounds like we agree! 😅 👍

@Beamanator Beamanator added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 15, 2024
@TMisiukiewicz
Copy link
Contributor

Just compared staging vs dev and noticed that on dev, the OpenApp API call is in pending state, and gets called again when back online. However, on staging this API call fails instantly when offline, and is not called again when back online 🤔

@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Feb 19, 2024

@TMisiukiewicz were you able to identify why?

@melvin-bot melvin-bot bot removed the Overdue label Feb 19, 2024
@TMisiukiewicz
Copy link
Contributor

@rlinoz unfortunately not yet, will look more into that once I'm done with my current tasks

@melvin-bot melvin-bot bot added the Overdue label Feb 21, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Feb 21, 2024

Should I add the help wanted label or are we looking at issues related to Troubleshooting somewhere?

cc: @techievivek @TMisiukiewicz

@melvin-bot melvin-bot bot removed the Overdue label Feb 21, 2024
@TMisiukiewicz
Copy link
Contributor

@rlinoz sorry for late response, I probably missed the notification. In the meantime there was another report for this issue created (#37116), however I am still working on some other stuff so I should have some time to dig into this issue next week

@melvin-bot melvin-bot bot added the Overdue label Feb 26, 2024
@trjExpensify
Copy link
Contributor

I don't think we need both of these issues open then do we? Shall we close this in favour of the one Tomasz is assigned to now?

@rlinoz
Copy link
Contributor

rlinoz commented Feb 26, 2024

They seem like different issues, but if @TMisiukiewicz thinks this is gonna be solved when we fix the other one, then I agree we can close this.

@melvin-bot melvin-bot bot removed the Overdue label Feb 26, 2024
@TMisiukiewicz
Copy link
Contributor

Let's keep this open for now, as they might be different issues

@rlinoz
Copy link
Contributor

rlinoz commented Feb 28, 2024

Moving this to weekly then, should I assign you?

@rlinoz rlinoz added the Weekly KSv2 label Feb 28, 2024
@rlinoz rlinoz removed the Daily KSv2 label Feb 28, 2024
@TMisiukiewicz
Copy link
Contributor

Yes, please assign me 👍

@TMisiukiewicz
Copy link
Contributor

@rlinoz I just tried it again a few times and each time it worked fine. One time it took pretty much lot of time to get the response from OpenApp, but in the end it loaded correctly. Could you take a look how does it work on your end?

@rlinoz
Copy link
Contributor

rlinoz commented Mar 4, 2024

Yep, it seems that it is working now.

I'm gonna close this one then, thanks!

@rlinoz rlinoz closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants