[Report Fields] [$500] [MEDIUM] Expense - Unable to unselect option in report field

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.42.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #36304

Action Performed:

Precondition: admin creates a Collect workspace in OD and invites an employee, admin sets up a dropdown field with a few options in Reports > Report and Invoice Fields

1. Open the app and log in as the employee
2. Navigate to the workspace room
3. Request money from the workspace
4. Open the report and then the report field "Field"
5. Select any option
6. Open the report field again and unselect the option

Expected Result:

The option is unselected, the checkmark is not displayed, and the report field is empty

Actual Result:

The option stays selected and is displayed in the report field. Also, the selected option is displayed in "Recent" instead of above "Recent" and "All" sections like in other places Category, tags

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6380799_1708009905864.Recording__211.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0119ace936e559d689
• Upwork Job ID: 1758162235501703168
• Last Price Increase: 2024-02-15
• Automatic offers:
• Ollyws | Reviewer | 0
• FitseTLT | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0119ace936e559d689

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kbecciv]

We think that this bug might be related #wave6-collect-submitters
cc @greg-schroeder

[neonbhai]

given that this is a regression from recent PR, we should probably have the deploy blocker label here

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to unselect option in report field

What is the root cause of that problem?

We are setting the selected value without checking it is the already selected one here

App/src/pages/EditReportFieldDropdownPage.tsx

Line 96 in 2d2e05f

onSelectRow={(option: Record<string, string>) => onSubmit({[fieldID]: option.text})}

What changes do you think we should make in order to solve the problem?

We should change it to

                        onSelectRow={(option: Record<string, string>) => onSubmit({[fieldID]: option.text === fieldValue ? '' : option.text})}

So that the empty string will not be added for recently used fields we need to change

App/src/libs/actions/Report.ts

Line 1556 in 2d2e05f

if (reportField.type === 'dropdown') {

App/src/libs/actions/Report.ts

Line 1584 in 2d2e05f

if (reportField.type === 'dropdown') {

to

    if (reportField.type === 'dropdown' && reportField.value) {

What alternative solutions did you explore? (Optional)

[Ollyws]

@FitseTLT's proposal LGTM.

There was also the issue of Also, the selected option is displayed in "Recent" instead of above "Recent" and "All" sections like in other places Category, tags but we can sort that out in the PR.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[greg-schroeder]

Next up is @grgia to confirm the contributor assignment here!

[melvin-bot]

📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@Ollyws, @greg-schroeder, @grgia, @FitseTLT Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Ollyws]

Not overdue, awaiting PR.

[grgia]

@FitseTLT could you give a ETA on the PR?

[FitseTLT]

Will be ready EOW

[greg-schroeder]

Bump @FitseTLT - do you have a Draft PR you can link as a starting point at least? Thanks!

[Ollyws]

Awaiting PR

[FitseTLT]

@Ollyws PR ready

[JmillsExpensify]

It looks like we've closed the linked PR, so shouldn't we close this issue as well as a result?

[greg-schroeder]

Closing!

[Ollyws]

@greg-schroeder I think according to section 19 of the process doc, in this situation payment is due for the C+ and contributor. Thanks.

[greg-schroeder]

sent offers to you both, you are correct

[Ollyws]

Accepted, thanks!