Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #140] [$500] Chat - Altering 1st code block removes markdown applied for quote & 2nd code block #36633

Closed
3 of 6 tasks
lanitochka17 opened this issue Feb 15, 2024 · 10 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 15, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.42
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4319035
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Launch app
  2. Tap on a report
  3. Type # 567
  4. In next line, type ||| |||
  5. Now from 1st pair- remove 5th block tick
  6. Note, removing 5th block tick in 1st pair, markdown applied for 2nd pair & for quote message also removed

Expected Result:

Removing 5th block tick in 1st pair, markdown applied for 2nd pair & for quote message must not be removed

Actual Result:

A quote message paired with 2 code block message is send. Altering 1st code block changes
quote and 2nd code block message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6381173_1708027679048.cod.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0194d1ba71ece129a2
  • Upwork Job ID: 1758228337378869248
  • Last Price Increase: 2024-02-15
@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 15, 2024
@melvin-bot melvin-bot bot changed the title Chat - Altering 1st code block removes markdown applied for quote & 2nd code block [$500] Chat - Altering 1st code block removes markdown applied for quote & 2nd code block Feb 15, 2024
Copy link

melvin-bot bot commented Feb 15, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0194d1ba71ece129a2

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 15, 2024
Copy link

melvin-bot bot commented Feb 15, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

Copy link

melvin-bot bot commented Feb 15, 2024

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp
CC @quinthar

@Christinadobrzyn
Copy link
Contributor

I can reproduce this but I don't think this is a priority unless there is some markdown reason for us to work on this now.

@hoangzinh what do you think? Should this be prioritised at this time?

@hoangzinh
Copy link
Contributor

@Christinadobrzyn I think we can track this markdown preview issue here #36071 and put it On Hold like this issue #36269. What do you think?

@tomekzaw
Copy link
Contributor

Duplicate of Expensify/react-native-live-markdown#179, fixed in Expensify/react-native-live-markdown#140, will be ported to Expensify/App in a separate PR.

@Christinadobrzyn Christinadobrzyn changed the title [$500] Chat - Altering 1st code block removes markdown applied for quote & 2nd code block [HOLD #140] [$500] Chat - Altering 1st code block removes markdown applied for quote & 2nd code block Feb 16, 2024
@Christinadobrzyn
Copy link
Contributor

Okay it sounds like we should hold for Expensify/react-native-live-markdown#140 and if that doesn't resolve it we'll add to #36071 and add another hold.

@Christinadobrzyn Christinadobrzyn added Weekly KSv2 and removed Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Feb 16, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 26, 2024
@Christinadobrzyn
Copy link
Contributor

Hold for Expensify/react-native-live-markdown#140

@melvin-bot melvin-bot bot removed the Overdue label Feb 26, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 6, 2024
@Christinadobrzyn
Copy link
Contributor

This appears to be fixed with Expensify/react-native-live-markdown#140

2024-03-07_14-01-26.mp4

Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants