[HOLD for payment 2024-04-25] [$500] Remove Save the World from Global Create, and move it into Settings

[zsgreenwald]

Problem

Global create is designed to call out quick actions to use New Expensify, whether its creating an expense or starting a chat. It's prime real estate for users to understand how to use our platform. Save the World is a unique campaign to help increase adoption, but it's not usable for everyone (especially those who don't know teachers). For that reason, it causes confusion and distraction from everything else in global create.

Solution

1. Remove Save The World from Global Create

2. Move Save The World over to Account Settings (by selecting the avatar) > Under the General section underneath About and Help. See below:

Notes:

• We'll want to confirm with design with icon we want to use
• We'll want to confirm the same RHP (right-hand pane) signup flow still works when it's selected. When someone clicks the new Save the World button, it'll take them to https://new.expensify.com/teachersunite while alsp sparning the RHP signup flow: See below for what the RHP looks like:

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ac6974700a830749
• Upwork Job ID: 1758271776871825408
• Last Price Increase: 2024-02-15
• Automatic offers:
• Ollyws | Reviewer | 0
• Amarparab2024 | Contributor | 0

Issue Owner

Current Issue Owner: @Amarparab2024

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ac6974700a830749

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[aeioual]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove Save the World from Global Create, and move it into Settings

What is the root cause of that problem?

New request

What changes do you think we should make in order to solve the problem?

We must remove the save the world part from below:

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

Lines 188 to 192 in 6fb924e

	{
	icon: Expensicons.Heart,
	text: translate('sidebarScreen.saveTheWorld'),
	onSelected: () => interceptAnonymousUser(() => Navigation.navigate(ROUTES.TEACHERS_UNITE)),
	},

And then move it under settings just below about over here:

App/src/pages/settings/InitialSettingsPage.js

Lines 231 to 235 in 6fb924e

	{
	translationKey: 'initialSettingsPage.about',
	icon: Expensicons.Info,
	routeName: ROUTES.SETTINGS_ABOUT,
	},

What alternative solutions did you explore? (Optional)

N/A

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove Save the World from Global Create, and move it into Settings

What is the root cause of that problem?

new feature

What changes do you think we should make in order to solve the problem?

move this code

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

Lines 188 to 192 in 6fb924e

	{
	icon: Expensicons.Heart,
	text: translate('sidebarScreen.saveTheWorld'),
	onSelected: () => interceptAnonymousUser(() => Navigation.navigate(ROUTES.TEACHERS_UNITE)),
	},

to

App/src/pages/settings/InitialSettingsPage.js

Lines 234 to 237 in 479203f

	},
	],
	}),
	[styles.pt4],

like this:

    const generaltMenuItemsData = useMemo(
        () => ({
            sectionStyle: {
                ...styles.pt4,
            },
            sectionTranslationKey: 'initialSettingsPage.general',
            items: [
                {
                    translationKey: 'initialSettingsPage.help',
                    icon: Expensicons.QuestionMark,
                    action: () => {
                        Link.openExternalLink(CONST.NEWHELP_URL);
                    },
                    iconRight: Expensicons.NewWindow,
                    shouldShowRightIcon: true,
                    link: CONST.NEWHELP_URL,
                },
                {
                    translationKey: 'initialSettingsPage.about',
                    icon: Expensicons.Info,
                    routeName: ROUTES.SETTINGS_ABOUT,
                },
                {
                    translationKey: 'sidebarScreen.saveTheWorld',
                    icon: Expensicons.Heart,
                    routeName: ROUTES.TEACHERS_UNITE,
                },
            ],
        }),
        [styles.pt4],
    );

[zsgreenwald]

I like the idea of keeping the heart as the icon, as mentioned here:

icon: Expensicons.Heart,

[Ollyws]

@Amarparab2024's proposal LGTM. Keep in mind we should preserve that interceptAnonymousUser()

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[badeggg]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove Save the World from Global Create, and move it into Settings

What is the root cause of that problem?

new feature request

What changes do you think we should make in order to solve the problem?

I don't think it's complete to simply move the place of link button. The 'save the world' page is not consistent with other account settings page.

1. (like other proposals say) Delete

   App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

   Lines 188 to 192 in d28f86f

   	{
   	icon: Expensicons.Heart,
   	text: translate('sidebarScreen.saveTheWorld'),
   	onSelected: () => interceptAnonymousUser(() => Navigation.navigate(ROUTES.TEACHERS_UNITE)),
   	},

   
   add similar config

                {
                   translationKey: 'sidebarScreen.saveTheWorld',
                   icon: Expensicons.Heart,
                   routeName: ROUTES.SETTINGS_SAVE_THE_WORLD,
                   action: () => {
                       interceptAnonymousUser(
                           waitForNavigate(() => {
                               Navigation.navigate(ROUTES.SETTINGS_SAVE_THE_WORLD);
                           })
                       );
                   },
               },

below code

App/src/pages/settings/InitialSettingsPage.js

Lines 231 to 235 in d28f86f

	{
	translationKey: 'initialSettingsPage.about',
	icon: Expensicons.Info,
	routeName: ROUTES.SETTINGS_ABOUT,
	},

2. Change file src/pages/TeachersUnite/SaveTheWorldPage.tsx to make it's layout align with other account settings items. The code change is too large to fit in this proposal, although it's not difficult. The result looks like:
   
   The icon need redesign, I demo it with PalmTree, which is used in 'about' setting page.

3. Other small code changes to coordinate the main change. e.g.
   add

        [SCREENS.SETTINGS.SAVE_THE_WORLD]: () => require('../../../pages/TeachersUnite/SaveTheWorldPage').default as React.ComponentType,

below

App/src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx

Line 196 in d28f86f

[SCREENS.SETTINGS.ABOUT]: () => require('../../../pages/settings/AboutPage/AboutPage').default as React.ComponentType,

What alternative solutions did you explore? (Optional)

N/A

[badeggg]

I don't think it's complete to simply move the place of link button. The 'save the world' page is not consistent with other account settings page. Especially on web. There is no other account setting items which show page content on right modal.

the 'save the world' page:

the 'about' page:

the 'security' page:

Hence my proposal.

[laurenreidexpensify]

@marcochavezf bump for review #36649 (comment) to assign thanks

[marcochavezf]

This proposal looks more complete since I agree we'd need to update the layout for the SaveTheWord page, though it was posted after C+ review. Said that, let's assign @Amarparab2024 and we can split the compensation if the PR ends up with some of @badeggg's suggested changes

[melvin-bot]

📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Amarparab2024 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[aeioual]

thanks for assigning @marcochavezf , the bug description wants the save the world to stay same as RHP, you can check the comments from the bug description :)

the same RHP (right-hand pane) signup flow still works when it's selected. When someone clicks the new Save the World button, it'll take them to https://new.expensify.com/teachersunite while alsp sparning the RHP signup flow: See below for what the RHP looks like:

[marcochavezf]

Oh interesting, but then that means the Save the world button won't be selected because the content of another page will be shown beneath the RHP. I will apply the Design label to gut-check if this is desired given the new design for the settings menu

[Ollyws]

What I was referring to was the route, which at the moment is https://new.expensify.com/teachersunite, as we will be moving it to settings the route will change to https://new.expensify.com/settings/teachersunite I'm wondering if we also need to preserve the initial route (https://new.expensify.com/teachersunite) as maybe it's linked by external websites? Or are we good to remove it?

[trjExpensify]

The https://new.expensify.com/teachersunite route is currently linked on our Expensify.org website, when you click the "Let's get started" button. We should of course update that, so it won't be a problem going forward.

The biggest reason to keep it would be because we sent a newsletter to everyone with the existing URL, which would be broken if someone clicks it now and we deprecate the route:

[mountiny]

@Ollyws Let's implement the https://new.expensify.com/settings/teachersunite route and we can add 301 reditect from https://new.expensify.com/teachersunite to https://new.expensify.com/settings/teachersunite to catch anyone coming from old links

[trjExpensify]

Yep, makes sense!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[laurenreidexpensify]

@marcochavezf ^^

[marcochavezf]

Deploy blocker being fixed here

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove Save the World from Global Create, and move it into Settings #37175

If no regressions arise, payment will be issued on 2024-04-25. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment automatic offer (Reviewer)
• @Amarparab2024 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[badeggg]

Can I get a split of the bounty?

[laurenreidexpensify]

Clarifying something internally - https://expensify.slack.com/archives/C01SKUP7QR0/p1714039326863999

[laurenreidexpensify]

Payment Summary:

C+ @Ollyws $500 payment in Upwork - please accept Contract
Contributor: @Amarparab2024 $500 payment issued in Upwork
Discretionary Bonus: @badeggg $100 payment in Upwork - please apply to job https://www.upwork.com/jobs/~01d337b089ca21ab6f

@badeggg as a one time exception we're issuing a discretionary bonus for your help in developing the solution

[Ollyws]

Accepted, thanks.

[badeggg]

Thanks, fair enough ;-)

[laurenreidexpensify]

• C+ @Ollyws $500 payment issued in Upwork
• Contributor: @Amarparab2024 $500 payment issued in Upwork
• Discretionary Bonus: @badeggg $100 - payment will be issued in Upwork once contract is firmed

@Ollyws can you please confirm re: regression steps thanks

[Ollyws]

I don't think a regression test is required here as it's just a design change. But if we were to add one it would be:

1. Go to Profile settings
2. Verify 'Save the world' is located above the signout button
3. Select 'Save the world' and verify it opens the save the world page

[laurenreidexpensify]

Yeah I agree - a regression test isn't needed thinking about it now.

All payments have been made, no outstanding tasks here, closing out. Thanks all!